Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(releasing): update procedure for extension #9989

Merged
merged 1 commit into from
Nov 19, 2019
Merged

docs(releasing): update procedure for extension #9989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clients/extension/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "__MSG_appName__",
"version": "5.6.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

"version": "100.0.0.0",
"minimum_chrome_version": "72",
"manifest_version": 2,
"description": "__MSG_appDescription__",
Expand Down
4 changes: 2 additions & 2 deletions docs/releasing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,15 +137,15 @@ npm publish
# Publish viewer.
yarn deploy-viewer

# Publish the extension.
# Publish the extension (if it changed).
open https://chrome.google.com/webstore/developer/edit/blipmdconlkpinefehnmjammfjpmpbjk
cd dist/extension-package/
echo "Upload the package zip to CWS dev dashboard..."
# Be in lighthouse-extension-owners group
# Open <https://chrome.google.com/webstore/developer/dashboard>
# Click _Edit_ on lighthouse
# _Upload Updated Package_
# Select `lighthouse-X.X.X.zip`
# Select `lighthouse-X.X.X.X.zip`
# _Publish_ at the bottom

# * Tell the world!!! *
Expand Down
4 changes: 2 additions & 2 deletions lighthouse-core/scripts/release/prepare-commit.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,11 @@ git checkout -b "$BRANCH_NAME"
# Install the dependencies.
yarn install

# Bump the version in package.json and clients/extension/manifest.json
# Bump the version in package.json
NEEDLE="^ \"version\": \"$SEMVER_PATTERN\""
REPLACEMENT=" \"version\": \"$NEW_VERSION\""

sed -i '' "s/$NEEDLE/$REPLACEMENT/g" package.json clients/extension/manifest.json
sed -i '' "s/$NEEDLE/$REPLACEMENT/g" package.json

# Update the fixtures with the new version
yarn update:sample-json
Expand Down