core: fix icu error thrown while throwing protocol error #9935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
Nov 6, 2019
exterkamp
approved these changes
Nov 6, 2019
yeah, but it also isn't guaranteed that these would be the right replacements for those future strings, either :) I think we'd want to revisit the |
brendankenny
changed the title
connorjclark
pushed a commit
that referenced
this pull request
Nov 7, 2019
connorjclark
added a commit
that referenced
this pull request
Nov 7, 2019
Squashed commit of the following: commit 1a053c4 Author: Connor Clark <[email protected]> Date: Wed Nov 6 17:31:14 2019 -0800 bundling for devtools commit 082715b Author: Brendan Kenny <[email protected]> Date: Wed Nov 6 18:41:52 2019 -0500 feedback commit 948ee09 Author: Brendan Kenny <[email protected]> Date: Tue Nov 5 17:50:55 2019 -0500 WIP: include plugin in dt build commit c2a4696 Author: Patrick Hulce <[email protected]> Date: Wed Nov 6 15:49:28 2019 -0600 core: delete full config (#9930) commit d53284c Author: Brendan Kenny <[email protected]> Date: Wed Nov 6 16:33:41 2019 -0500 core: fix icu error thrown while throwing protocol error (#9935)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9882
We could probably revisit how these protocol errors are generated because this function predates all of the i18n work and most of LHError handling, but this is the easy fix for now.
All of the LHErrors that have patterns to match use the same message, which doesn't have any replacements, so these arguments can safely be removed.