core: add new base artifact, HostFormFactor #9923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
Nov 6, 2019
connorjclark
commented
Nov 6, 2019
| @@ -456,14 +456,15 @@ class GatherRunner { | |||
|
|
|||
| const {emulatedFormFactor} = options.settings; | |||
| // Whether Lighthouse was run on a mobile device (i.e. not on a desktop machine). | |||
| const IsMobileHost = hostUserAgent.includes('Android') || hostUserAgent.includes('Mobile'); | |||
| const HostFormFactor = /android|mobile/i.test(hostUserAgent) ? 'mobile' : 'desktop'; | |||
There was a problem hiding this comment.
paul called me names (not out loud, but in his head) for wanting to use a regex here
There was a problem hiding this comment.
so you want to use a regex. now you got 2 problems 3 problems, including name-calling.
🙃
case insensitivity is fine. CONFIDENT PROGRAMMING. WE"LL BE FINE.
- https://cs.chromium.org/chromium/src/components/cronet/android/java/src/org/chromium/net/impl/UserAgent.java?l=42&rcl=0efaa7ede88f9448f19193dc513e57d651cabe79
- https://cs.chromium.org/chromium/src/third_party/devtools-frontend/src/node_modules/useragent/lib/regexps.js?l=727&rcl=879d97b05dfe9f26ede820b0296b125d4a68e5ff
surely.
brendankenny
reviewed
Nov 6, 2019
| @@ -29,6 +29,8 @@ declare global { | |||
| LighthouseRunWarnings: string[]; | |||
| /** Whether the page was loaded on either a real or emulated mobile device. */ | |||
| TestedAsMobileDevice: boolean; | |||
| /** Device which Chrome is running on. */ | |||
| HostFormFactor: 'desktop'|'mobile'; | |||
There was a problem hiding this comment.
TestedAsMobileDevice
HostUserAgent
NetworkUserAgent
HostFormFactor
emulatedFormFactor
deviceScreenEmulationMethod
https://www.theonion.com/taco-bells-five-ingredients-combined-in-totally-new-way-1819564909
brendankenny
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #9911.
Needed for #9713