misc: upgrade lhci dogfood script #9879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
approved these changes
Oct 23, 2019
|
|
||
| # Kill the static server from earlier. | ||
| kill $! | ||
| lhci upload --serverBaseUrl="$LHCI_CANARY_SERVER_URL" --token="$LHCI_CANARY_SERVER_TOKEN" --github-token="$BUNDLESIZE_GITHUB_TOKEN" |
There was a problem hiding this comment.
--github-token="$BUNDLESIZE_GITHUB_TOKEN"
I assume this works and has a good reason to happen :)
There was a problem hiding this comment.
Works great :)
Haha, yeah we just need any github token that can set status checks on our repo, so seemed better to reuse than have two floating around with potentially wider access?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
lhci now has a built-in static server we can use that does compression and other sensible things, we should also be getting status checks for LHCI when it runs