core(config): enable unused-javascript by default #9854
Conversation
| @@ -16,7 +16,7 @@ class JsUsage extends Gatherer { | |||
| */ | |||
| async beforePass(passContext) { | |||
| await passContext.driver.sendCommand('Profiler.enable'); | |||
| await passContext.driver.sendCommand('Profiler.startPreciseCoverage'); | |||
| await passContext.driver.sendCommand('Profiler.startPreciseCoverage', {detailed: false}); | |||
There was a problem hiding this comment.
To be certain we're on the same page, is this what was meant by function-level @bmeurer? Or is it only getBestEffortCoverage that has the characteristics we're discussing?
There was a problem hiding this comment.
Yes this gives you function-level coverage. The best effort coverage is not supported since it's unreliable and misleading, and we will likely remove that in the future.
|
see if we can also cc @sigurdschneider in here :) |
|
Do we want this for 6.0? |
I say we do it :) Any more objections? |
| @@ -9,25 +9,6 @@ | |||
| const fullConfig = { | |||
There was a problem hiding this comment.
delete the file maybe? breaking change opportunity and all that.
There was a problem hiding this comment.
that ended up being somewhat large of a change, so new PR #9930 👍
Summary
See the excellent summary in #9853 :)
Related Issues/PRs
closes #9853