Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(lightwallet): adds computed/timing-summary.js (refactor) #9814

Merged
merged 8 commits into from
Oct 22, 2019
Merged

core(lightwallet): adds computed/timing-summary.js (refactor) #9814

merged 8 commits into from
Oct 22, 2019

Conversation

khempenius
Copy link
Collaborator

This moves the code that generates UberMetricsItem from audits/metrics.js to computed/timing-summary.js. This will allow timing budgets to re-use the same logic.

Related Issues
(same issue, filed two different places)

patrickhulce
patrickhulce suggested changes Oct 10, 2019
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this move! probably should've started as a computed artifact anyhow :)

lighthouse-core/test/results/sample_v2.json Show resolved Hide resolved
lighthouse-core/test/computed/metrics/timing-summary-test.js Outdated Show resolved Hide resolved
lighthouse-core/computed/metrics/timing-summary.js Show resolved Hide resolved
patrickhulce
patrickhulce reviewed Oct 10, 2019
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to me if we get that nesting sorted out! :)

types/artifacts.d.ts Outdated Show resolved Hide resolved
types/artifacts.d.ts Outdated Show resolved Hide resolved
lighthouse-core/test/results/artifacts/artifacts.json Outdated Show resolved Hide resolved
patrickhulce
patrickhulce suggested changes Oct 15, 2019
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

structure all looks great still! a few things left to cleanup 👍

lighthouse-core/audits/metrics.js Show resolved Hide resolved
lighthouse-core/audits/metrics.js Outdated Show resolved Hide resolved
lighthouse-core/computed/metrics/timing-summary.js Outdated Show resolved Hide resolved
lighthouse-core/computed/metrics/timing-summary.js Outdated Show resolved Hide resolved
lighthouse-core/test/computed/metrics/timing-summary-test.js Outdated Show resolved Hide resolved
lighthouse-core/test/results/sample_v2.json Outdated Show resolved Hide resolved
patrickhulce
patrickhulce approved these changes Oct 16, 2019
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lighthouse-core/computed/metrics/timing-summary.js Show resolved Hide resolved
@patrickhulce patrickhulce merged commit dab0201 into GoogleChrome:master Oct 22, 2019
@brendankenny brendankenny mentioned this pull request Nov 4, 2019
Merged
paulirish pushed a commit that referenced this pull request Nov 6, 2019
@khempenius @paulirish
core(lightwallet): adds computed/timing-summary.js (refactor) (#9814)
872e970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@brendankenny brendankenny Awaiting requested review from brendankenny

@exterkamp exterkamp Awaiting requested review from exterkamp

@paulirish paulirish Awaiting requested review from paulirish

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khempenius @patrickhulce @googlebot