Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: center and style top-level runtimeError #9271

Merged
merged 7 commits into from
Jun 26, 2019
Merged

report: center and style top-level runtimeError #9271

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6cc1b25
report: center toplevel errors
connorjclark Jun 24, 2019
5211794
bg color
connorjclark Jun 24, 2019
3874628
breakpoint
connorjclark Jun 24, 2019
0ef6187
amber-50
connorjclark Jun 25, 2019
e82ed83
padding
connorjclark Jun 25, 2019
cb05e64
better
connorjclark Jun 25, 2019
231c891
Merge remote-tracking branch 'origin/master' into report-toplevel-err…
connorjclark Jun 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions lighthouse-core/report/html/report-styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
.lh-vars {
/* Palette using Material Design Colors
* https://www.materialui.co/colors */
--color-amber: #FFF8E1; /* 50 */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what 50 means

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I was confused too until I looked up the material ui table :) https://www.materialui.co/colors

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, in that case, should be part of the name.

Omit "-{intensity}" if there is only one color of that hue.

isn't simplifying anything if it's helpful enough to have the intensity that we add it in a comment :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

--color-blue-200: #90CAF9;
--color-blue-900: #0D47A1;
--color-blue-A700: #2962FF;
Expand Down Expand Up @@ -993,9 +994,17 @@
.lh-warnings--toplevel {
--item-margin: calc(var(--header-line-height) / 4);
color: var(--report-text-color-secondary);
margin: var(--category-padding);
padding: var(--category-padding);
margin-left: auto;
margin-right: auto;
width: 50%;
patrickhulce marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

50% seems a little arbitrary and has the box edges not matching up with the "grid" of the report.

max-width: calc(var(--report-width) - var(--category-padding) * 2);

this'll have it match most of the report content.

background-color: var(--color-amber);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels like we might want a bit more padding with the new background style 🤷‍♂

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done and updated images

}
@media screen and (max-width: 964px) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once the max-width is applied you can drop this whole MQ and rule

.lh-warnings--toplevel {
width: 100%;
}
}

.lh-warnings ul {
padding-left: calc(var(--category-padding) * 2);
margin: 0;
Expand Down