misc(gulp): rename output files #6179

wardpeet · 2018-10-05T16:07:36Z

Summary
renaming consumer's files:
devtools-entry.js => lighthouse-dt-bundle.js
extension-entry.js => lighthouse-ext-bundle.js
lightrider-entry.js => lighthouse-lr-bundle.js

also removed debug from browserify which I accidentally added.

$ gulp build:production
[18:13:07] Using gulpfile /c/Users/WardPeeters/Projects/os/lighthouse/lighthouse-extension/gulpfile.js
[18:13:07] Starting 'build:production'...
[18:13:07] Starting 'build'...
[18:13:07] Starting 'lint'...
[18:13:07] Finished 'lint' after 647 ms
[18:13:07] Starting 'browserify'...
[18:13:07] Starting 'browserify-lighthouse'...
[18:13:07]  app/src/devtools-entry.js
[18:13:07] renamed into: app/src/lighthouse-dt-bundle.js
[18:13:07]  app/src/extension-entry.js
[18:13:07] renamed into: app/src/lighthouse-ext-bundle.js
[18:13:07]  app/src/lightrider-entry.js
[18:13:07] renamed into: app/src/lighthouse-lr-bundle.js
[18:13:07]  3 items
[18:13:07] renamed into: 3 items
[18:13:15] Finished 'browserify-lighthouse' after 7.67 s
[18:13:15] Starting 'browserify-other'...
[18:13:15] Finished 'browserify-other' after 86 ms
[18:13:15] Finished 'browserify' after 7.76 s
[18:13:15] Starting 'chromeManifest'...
[18:13:15] Finished 'chromeManifest' after 166 ms
[18:13:15] Starting 'html'...
[18:13:15] Starting 'images'...
[18:13:15] Starting 'css'...
[18:13:15] Starting 'extras'...
[18:13:15] copying to dist: app/_locales
[18:13:15] copying to dist: app/_locales/en
[18:13:15] copying to dist: app/_locales/en/messages.json
[18:13:15] copying to dist: app/_locales/en/messages_canary.json
[18:13:15] copying to dist: 4 items
[18:13:15] Finished 'html' after 19 ms
[18:13:15] Finished 'css' after 36 ms
[18:13:15] Finished 'extras' after 41 ms
[18:13:15] Finished 'images' after 60 ms
[18:13:15] Finished 'build' after 8.64 s
[18:13:15] Starting 'compilejs'...
[18:13:24] Finished 'compilejs' after 8.33 s
[18:13:24] Finished 'build:production' after 17 s

sizes are intact, there is a small diff but it's just whitespace

-rw-rw-rw- 1 0 0 1354774 Oct  5 18:28 lighthouse-background.js
-rw-rw-rw- 1 0 0 1354379 Oct  5 18:27 lighthouse-dt-bundle.js
-rw-rw-rw- 1 0 0 1525837 Oct  5 18:28 lighthouse-ext-background.js
-rw-rw-rw- 1 0 0 1525425 Oct  5 18:27 lighthouse-ext-bundle.js
-rw-rw-rw- 1 0 0 2568125 Oct  5 18:28 lighthouse-lr-background.js
-rw-rw-rw- 1 0 0 2567727 Oct  5 18:27 lighthouse-lr-bundle.js

Related Issues/PRs

#6170

wardpeet · 2018-10-05T16:08:01Z

package.json

@@ -157,7 +157,15 @@
  },
  "bundlesize": [
    {
-      "path": "./lighthouse-extension/dist/scripts/lighthouse-background.js",
+      "path": "./lighthouse-extension/dist/scripts/lighthouse-dt-bundle.js",


unsure which one to check or if we should check them all 3

let's check ext bundle since it's the most of our code but without worrying about string changes

wardpeet · 2018-10-05T16:08:39Z

I tried using gulp-rename but it did not copy my whole file for some reason so I switched to a tap instance.

wardpeet · 2018-10-05T17:24:46Z

@paulirish could you check roll out to devtools?

paulirish

works great. thx!

paulirish · 2018-10-09T21:28:46Z

package.json

@@ -157,7 +157,15 @@
  },
  "bundlesize": [
    {
-      "path": "./lighthouse-extension/dist/scripts/lighthouse-background.js",
+      "path": "./lighthouse-extension/dist/scripts/lighthouse-dt-bundle.js",


let's check ext bundle since it's the most of our code but without worrying about string changes

brendankenny

excited about this!

brendankenny · 2018-10-10T01:02:52Z

docs/releasing.md

@@ -93,8 +93,8 @@ git push --tags
 echo "Rebuild extension and viewer to get the latest, tagged master commit"
 yarn build-all;

-# zip the extension files, but remove lh-background as it's not needed
-cd lighthouse-extension; command rm -f dist/scripts/lighthouse-background.js; gulp package; cd ..


we should really update gulp package to do this for us. I've definitely never remembered to delete the other files :):)

i'll add a new PR that fixes this.

@brendankenny see #6210

brendankenny · 2018-10-10T01:08:24Z

lighthouse-extension/gulpfile.js

-const isDevtools = file => file.endsWith(CONSUMERS.DEVTOOLS);
-const isExtension = file => file.endsWith(CONSUMERS.EXTENSION);
+const isDevtools = file =>
+  file.endsWith(CONSUMERS.DEVTOOLS.src) || file.endsWith(CONSUMERS.DEVTOOLS.dist);


can the dist file really ever go through this function?

probably not but wanted to be save but i'm removing it

brendankenny · 2018-10-10T01:10:23Z

lighthouse-extension/test/app/srclightrider-entry.js

@@ -6,12 +6,12 @@
 'use strict';


I think you missed a / in the git mv :)

oh nice thanks

brendankenny · 2018-10-10T01:12:09Z

lighthouse-extension/app/src/extension-entry.js

@@ -6,7 +6,7 @@
 'use strict';

 const lighthouse = require('../../../lighthouse-core/index');
-const background = require('./lighthouse-background');
+const background = require('./devtools-entry');


it's unfortunate to have to keep calling this background, but I can't think of a better name right now :)

if I move getDefaultConfigForCategories & getDefaultCategories to it's own file called one of them below I could rename the variable which gives more meaning to it.

config.js,

helpers/config.js

optionsHelper.js

runOptions.js

lighthouseOptions.js

...

yeah, I think that makes sense, but I think we should just wait on it (at least until LR shakes out and we can fully see the shape of these files for the medium-term future).

wardpeet requested review from patrickhulce and paulirish as code owners October 5, 2018 16:07

wardpeet commented Oct 5, 2018

View reviewed changes

wardpeet added 2 commits October 5, 2018 18:24

misc(gulp): rename output files

1d52369

fix test

174e085

wardpeet force-pushed the chore/rename-ext branch from aeb51d6 to 174e085 Compare October 5, 2018 16:35

paulirish approved these changes Oct 9, 2018

View reviewed changes

brendankenny reviewed Oct 10, 2018

View reviewed changes

wardpeet added 3 commits October 10, 2018 20:05

only check for ext bundlesize

c97afe6

fix rename

a5742dd

remove dist file checks from isDevtools & isExtension

a3806c4

wardpeet mentioned this pull request Oct 10, 2018

misc(build): cleanup extension package zip using gulp #6210

Merged

paulirish merged commit 32b02f1 into master Oct 10, 2018

paulirish deleted the chore/rename-ext branch October 10, 2018 23:56

brendankenny mentioned this pull request Oct 11, 2018

tests: restore lr-entry test as a test #6214

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

misc(gulp): rename output files #6179

misc(gulp): rename output files #6179

wardpeet commented Oct 5, 2018 •

edited

Loading

wardpeet Oct 5, 2018

paulirish Oct 9, 2018

wardpeet commented Oct 5, 2018

wardpeet commented Oct 5, 2018

paulirish left a comment

paulirish Oct 9, 2018

brendankenny left a comment

brendankenny Oct 10, 2018

wardpeet Oct 10, 2018

wardpeet Oct 10, 2018

brendankenny Oct 10, 2018

wardpeet Oct 10, 2018

brendankenny Oct 10, 2018

wardpeet Oct 10, 2018

brendankenny Oct 10, 2018

wardpeet Oct 10, 2018 •

edited

Loading

brendankenny Oct 10, 2018

misc(gulp): rename output files #6179

misc(gulp): rename output files #6179

Conversation

wardpeet commented Oct 5, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wardpeet commented Oct 5, 2018

wardpeet commented Oct 5, 2018

paulirish left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brendankenny left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wardpeet Oct 10, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wardpeet commented Oct 5, 2018 •

edited

Loading

wardpeet Oct 10, 2018 •

edited

Loading