core(lr): add LR presets for desktop and mobile

lighthouse-core/config/lr-desktop-config.js

@@ -0,0 +1,23 @@
+/**
+ * @license Copyright 2018 Google Inc. All Rights Reserved.
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+ */
+'use strict';
+
+/** @type {LH.Config.Json} */
+const config = {
+  extends: 'lighthouse:default',
+  settings: {
+    disableDeviceEmulation: true,
+    throttling: {
+      // Using a "broadband" connection type
+      // Corresponds to "Dense 4G 25th percentile" in https://docs.google.com/document/d/1Ft1Bnq9-t4jK5egLSOc28IL4TvR-Tt0se_1faTA4KTY/edit#heading=h.bb7nfy2x9e5v
+      rttMs: 40,
+      throughputKbps: 10 * 1024,
+      cpuSlowdownMultiplier: 1,
+    },
+  },
+};
+
+module.exports = config;

lighthouse-core/config/lr-mobile-config.js

@@ -0,0 +1,14 @@
+/**
+ * @license Copyright 2018 Google Inc. All Rights Reserved.
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+ */
+'use strict';
+
+/** @type {LH.Config.Json} */
+const config = {
+  extends: 'lighthouse:default',
+  settings: {},
+};
+
+module.exports = config;

lighthouse-extension/app/src/lighthouse-ext-background.js

@@ -12,6 +12,12 @@ const ExtensionProtocol = require('../../../lighthouse-core/gather/connections/e
 const log = require('lighthouse-logger');
 const assetSaver = require('../../../lighthouse-core/lib/asset-saver.js');
 
+/** @type {Record<'mobile'|'desktop', LH.Config.Json>} */
+const LR_PRESETS = {
+  mobile: require('../../../lighthouse-core/config/lr-mobile-config'),
+  desktop: require('../../../lighthouse-core/config/lr-desktop-config'),
+};
+
 /** @typedef {import('../../../lighthouse-core/gather/connections/connection.js')} Connection */
 
 const STORAGE_KEY = 'lighthouse_audits';
@@ -85,13 +91,23 @@ async function runLighthouseInExtension(flags, categoryIDs) {
  * @param {Connection} connection
  * @param {string} url
  * @param {LH.Flags} flags Lighthouse flags, including `output`
- * @param {Array<string>} categoryIDs Name values of categories to include.
- * @param {{logAssets: boolean}} lrOpts Options coming from Lightrider
+ * @param {{lrDevice?: 'desktop'|'mobile', categoryIDs?: Array<string>, logAssets: boolean}} lrOpts Options coming from Lightrider
  * @return {Promise<string|Array<string>|void>}
  */
-async function runLighthouseAsInCLI(connection, url, flags, categoryIDs, {logAssets}) {
+async function runLighthouseInLR(connection, url, flags, {lrDevice, categoryIDs, logAssets}) {
+  // Override default device to be desktop, since LR default device has viewport 1x1.
+  connection.sendCommand('Emulation.setDeviceMetricsOverride',
+    {width: 800, height: 600, deviceScaleFactor: 0, mobile: false});
+
+  // disableStorageReset because it causes render server hang
+  flags.disableStorageReset = true;
   flags.logLevel = flags.logLevel || 'info';
-  const config = background.getDefaultConfigForCategories(categoryIDs);
+  const config = lrDevice === 'desktop' ? LR_PRESETS.desktop : LR_PRESETS.mobile;
+  if (categoryIDs) {
+    config.settings = config.settings || {};
+    config.settings.onlyCategories = categoryIDs;
+  }
+
   const results = await lighthouse(url, flags, config, connection);
   if (!results) return;
 
@@ -217,7 +233,7 @@ if (typeof module !== 'undefined' && module.exports) {
 // @ts-ignore
 window.runLighthouseInExtension = runLighthouseInExtension;
 // @ts-ignore
-window.runLighthouseAsInCLI = runLighthouseAsInCLI;
+window.runLighthouseInLR = runLighthouseInLR;
 // @ts-ignore
 window.getDefaultCategories = background.getDefaultCategories;
 // @ts-ignore