-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce computedArtifacts #583
Conversation
I'm not clear on exactly what the change proposes. How does computedArtifacts sit alongside artifacts? |
#542 has some backstory, but I'll elaborate here. This was motivated by two things:
This PR makes a semantic change between these two categories.
And lastly, functionally, this PR adds an async interface onto the |
There are a few in-between artifacts that have been generated from the trace & networkRecords. However they can be lazily created, which simplifies the scheduling of items like speedline, and reduces complexity when importing artifacts from the config.
Additionally, this also means we can cache the results of our computedArtifacts, which will speed up generation of
speedline
,DevtoolsTimelineModel
, andTracingModel
.This PR moves 3 gatherers into be computedArtifacts:
speedline
,screenshots
, andcritical network chains
.Once landed, I'll followup with porting
DevtoolsTimelineModel
, andTracingModel
into the same setup. (With the latest version of speedline, we can now pass a completeDevtoolsTimelineModel
into it, the same we'll share for our own measurements. This will take care of another ~1-4s of latency during reporting)fixes #542