tests: better display value tests with i18n #5720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
approved these changes
Jul 25, 2018
There was a problem hiding this comment.
I knew jest was a going to be a trojan horse for expect(whatever).to.need.a.silly.assertion(true) :P
This works for me for #5716, if the rest are copied over?
typings/externs.d.ts
Outdated
| @@ -184,3 +184,9 @@ declare global { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| declare namespace jest { | |||
lighthouse-core/test/test-utils.js
Outdated
|
|
||
| expect.extend({ | ||
| toHaveDisplayValue(received, expected) { | ||
| const obj = {displayValue: received.displayValue}; |
There was a problem hiding this comment.
it looks like this and logging is the only displayValue specific stuff in here. Do we want a more generalized toHaveLocalizedWhatever()?
yep 👍 |
patrickhulce
force-pushed
the
better_display_value_tests
branch
from
9f3191e to
4cd5d26
Compare
patrickhulce
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brendankenny we do this post #5716 ?