core: remove dependency on devtools-frontend NetworkRequest

lighthouse-core/audits/byte-efficiency/byte-efficiency-audit.js

@@ -82,11 +82,11 @@ class UnusedBytes extends Audit {
       return Math.round(totalBytes * compressionRatio);
     } else if (networkRecord._resourceType && networkRecord._resourceType._name === resourceType) {
       // This was a regular standalone asset, just use the transfer size.
-      return networkRecord._transferSize || 0;
+      return networkRecord.transferSize || 0;
     } else {
       // This was an asset that was inlined in a different resource type (e.g. HTML document).
       // Use the compression ratio of the resource to estimate the total transferred bytes.
-      const transferSize = networkRecord._transferSize || 0;
+      const transferSize = networkRecord.transferSize || 0;
       const resourceSize = networkRecord._resourceSize;
       const compressionRatio = resourceSize !== undefined ? (transferSize / resourceSize) : 1;
       return Math.round(totalBytes * compressionRatio);
@@ -149,11 +149,12 @@ class UnusedBytes extends Audit {
       const networkNode = /** @type {NetworkNode} */ (node);
       const result = resultsByUrl.get(networkNode.record.url);
       if (!result) return;
+
       const original = networkNode.record.transferSize;
-      // cloning NetworkRequest objects is difficult, so just stash the original transfer size
       originalTransferSizes.set(networkNode.record.requestId, original);
 
       const wastedBytes = result.wastedBytes;
+      networkNode.record.transferSize = Math.max(original - wastedBytes, 0);
       networkNode.record._transferSize = Math.max(original - wastedBytes, 0);
     });
 
@@ -165,6 +166,7 @@ class UnusedBytes extends Audit {
       const networkNode = /** @type {NetworkNode} */ (node);
       const originalTransferSize = originalTransferSizes.get(networkNode.record.requestId);
       if (originalTransferSize === undefined) return;
+      networkNode.record.transferSize = originalTransferSize;
       networkNode.record._transferSize = originalTransferSize;
     });
 

lighthouse-core/audits/byte-efficiency/render-blocking-resources.js

@@ -158,17 +158,17 @@ class RenderBlockingResources extends Audit {
       if (canDeferRequest && isStylesheet) {
         // We'll inline the used bytes of the stylesheet and assume the rest can be deferred
         const wastedBytes = wastedCssBytesByUrl.get(networkNode.record.url) || 0;
-        totalChildNetworkBytes += (networkNode.record._transferSize || 0) - wastedBytes;
+        totalChildNetworkBytes += (networkNode.record.transferSize || 0) - wastedBytes;
       }
       return !canDeferRequest;
     }));
 
     // Add the inlined bytes to the HTML response
-    const originalTransferSize = minimalFCPGraph.record._transferSize;
+    const originalTransferSize = minimalFCPGraph.record.transferSize;
     const safeTransferSize = originalTransferSize || 0;
-    minimalFCPGraph.record._transferSize = safeTransferSize + totalChildNetworkBytes;
+    minimalFCPGraph.record.transferSize = safeTransferSize + totalChildNetworkBytes;
     const estimateAfterInline = simulator.simulate(minimalFCPGraph).timeInMs;
-    minimalFCPGraph.record._transferSize = originalTransferSize;
+    minimalFCPGraph.record.transferSize = originalTransferSize;
     return Math.round(Math.max(originalEstimate - estimateAfterInline, 0));
   }
 

lighthouse-core/audits/time-to-first-byte.js

@@ -6,7 +6,6 @@
 'use strict';
 
 const Audit = require('./audit');
-const Util = require('../report/html/renderer/util');
 
 const TTFB_THRESHOLD = 600;
 
@@ -29,8 +28,7 @@ class TTFBMetric extends Audit {
    */
   static caclulateTTFB(record) {
     const timing = record._timing;
-
-    return timing.receiveHeadersEnd - timing.sendEnd;
+    return timing ? timing.receiveHeadersEnd - timing.sendEnd : 0;
   }
 
   /**
@@ -42,6 +40,7 @@ class TTFBMetric extends Audit {
 
     return artifacts.requestNetworkRecords(devtoolsLogs)
       .then((networkRecords) => {
+        /** @type {LH.Audit.DisplayValue} */
         let displayValue = '';
 
         const finalUrl = artifacts.URL.finalUrl;
@@ -53,7 +52,7 @@ class TTFBMetric extends Audit {
         const passed = ttfb < TTFB_THRESHOLD;
 
         if (!passed) {
-          displayValue = `Root document took ${Util.formatMilliseconds(ttfb, 1)} `;
+          displayValue = ['Root document took %10d', ttfb];
         }
 
         /** @type {LH.Result.Audit.OpportunityDetails} */

lighthouse-core/audits/uses-rel-preconnect.js

@@ -38,7 +38,7 @@ class UsesRelPreconnectAudit extends Audit {
    * @return {boolean}
    */
   static hasValidTiming(record) {
-    return record._timing && record._timing.connectEnd > 0 && record._timing.connectStart > 0;
+    return !!record._timing && record._timing.connectEnd > 0 && record._timing.connectStart > 0;
   }
 
   /**
@@ -48,6 +48,7 @@ class UsesRelPreconnectAudit extends Audit {
    */
   static hasAlreadyConnectedToOrigin(record) {
     return (
+      !!record._timing &&
       record._timing.dnsEnd - record._timing.dnsStart === 0 &&
       record._timing.connectEnd - record._timing.connectStart === 0
     );
@@ -90,7 +91,7 @@ class UsesRelPreconnectAudit extends Audit {
           // filter out all resources where timing info was invalid
           !UsesRelPreconnectAudit.hasValidTiming(record) ||
           // filter out all resources that are loaded by the document
-          record.initiatorRequest() === mainResource ||
+          record._initiator.url === mainResource.url ||
           // filter out urls that do not have an origin (data, ...)
           !record.parsedURL || !record.parsedURL.securityOrigin() ||
           // filter out all resources that have the same origin
@@ -118,6 +119,9 @@ class UsesRelPreconnectAudit extends Audit {
         return (record.startTime < firstRecord.startTime) ? record: firstRecord;
       });
 
+      // Skip the origin if we don't have timing information
+      if (!firstRecordOfOrigin._timing) return;
+
       const securityOrigin = firstRecordOfOrigin.parsedURL.securityOrigin();
 
       // Approximate the connection time with the duration of TCP (+potentially SSL) handshake

lighthouse-core/gather/driver.js

@@ -586,7 +586,7 @@ class Driver {
    * @private
    */
   _beginNetworkStatusMonitoring(startingUrl) {
-    this._networkStatusMonitor = new NetworkRecorder([]);
+    this._networkStatusMonitor = new NetworkRecorder();
 
     // Update startingUrl if it's ever redirected.
     this._monitoredUrl = startingUrl;