Faster smoketest. Fix Flaky works-offline gather #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samccone ptal! |
| @@ -3,34 +3,36 @@ | |||
| cd lighthouse-cli/test/fixtures && python -m SimpleHTTPServer 9999 & | |||
|
|
|||
| NODE=$([ $(node -v | grep -E "v4") ] && echo "node --harmony" || echo "node") | |||
| offline200result="URL responds with a 200 when offline" | |||
| config="$PWD/lighthouse-cli/test/fixtures/smoketest-config.json" | |||
| flags="--audit-whitelist=works-offline,viewport --config-path=$config" | |||
There was a problem hiding this comment.
I don't think we need both an audit-whitelist and a custom config path. The whitelist works to remove unnecessary audits from the default config, but if using a custom config the audit list is already smaller.
There was a problem hiding this comment.
I don't think we need both an audit-whitelist and a custom config path.
true. only need the config. Will take care of that.
|
audit-whitelist removed. killed the boolean trap. |
| static goOffline(driver) { | ||
| return driver.sendCommand('Network.emulateNetworkConditions', { | ||
| offline: true, | ||
| static config(opts) { |
There was a problem hiding this comment.
{offline} here would be reeeeeal nice :)
There was a problem hiding this comment.
sure but we're not using destructuring as we need to support node v4 w/ --harmony
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The smoketest is now massively faster. We use a custom config and audit-whitelist for our run to be super fast.
There was flakiness with the works-offline test. As it turns out
network.enablemust be on before offline is triggered.