Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli(chrome-launcher): remove chrome-launcher forwarding stubs #4945

Merged
merged 1 commit into from
Apr 10, 2018
Merged

cli(chrome-launcher): remove chrome-launcher forwarding stubs #4945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions chrome-launcher/README.md
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions chrome-launcher/chrome-launcher.js
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions chrome-launcher/index.js
View file
Open in desktop

This file was deleted.

10 changes: 1 addition & 9 deletions chrome-launcher/manual-chrome-launcher.js → ...se-core/scripts/manual-chrome-launcher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,6 @@

'use strict';

/**
* chrome-launcher has moved to its own repository and npm package.
* https://github.com/GoogleChrome/chrome-launcher
* https://www.npmjs.com/package/chrome-launcher
* This script preserved for Lighthouse's chrome-debug binary, but but file and
* bin entry will be removed in next major release.
*/

/**
* @fileoverview Script to launch a clean Chrome instance on-demand.
*
Expand All @@ -34,7 +26,7 @@ if (args.length) {
chromeFlags = args.filter(flag => flag.startsWith('--'));

const portFlag = chromeFlags.find(flag => flag.startsWith('--port='));
port = portFlag && portFlag.replace('--port=', '');
if (portFlag) port = parseInt(portFlag.replace('--port=', ''), 10);

enableExtensions = !!chromeFlags.find(flag => flag === '--enable-extensions');

Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"main": "./lighthouse-core/index.js",
"bin": {
"lighthouse": "./lighthouse-cli/index.js",
"chrome-debug": "./chrome-launcher/manual-chrome-launcher.js"
"chrome-debug": "./lighthouse-core/scripts/manual-chrome-launcher.js"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one option:

we remove this from the lh package and setup the bin over in chrome-launcher.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have yarn chrome now I'm fine removing chrome-debug, but I also don't install lighthouse globally anyways. It probably makes sense to not install with lighthouse? cc @patrickhulce

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine either way, I don't use chrome-debug these days

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after discussion, chrome-debug is still useful for testing a site requiring authentication with a global lighthouse install, so leaving for now

},
"engines": {
"node": ">=8"
Expand Down Expand Up @@ -45,7 +45,7 @@
"closure": "cd lighthouse-core && node closure/closure-type-checking.js",
"devtools": "bash lighthouse-core/scripts/roll-to-devtools.sh",
"compile-devtools": "bash lighthouse-core/scripts/compile-against-devtools.sh",
"chrome": "node chrome-launcher/manual-chrome-launcher.js",
"chrome": "node lighthouse-core/scripts/manual-chrome-launcher.js",
"fast": "yarn start --disable-device-emulation --disable-cpu-throttling --disable-network-throttling",
"smokehouse": "node lighthouse-cli/test/smokehouse/smokehouse.js",
"deploy-viewer": "cd lighthouse-viewer && gulp deploy",
Expand Down