Switch to using standalone chrome-launcher package #3410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
force-pushed
the
launchlauncher
branch
from
bf9c951 to
403b6a9
Compare
paulirish
approved these changes
Sep 25, 2017
patrickhulce
approved these changes
Sep 25, 2017
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finishes(?) GoogleChrome/chrome-launcher#16
Per that thread, maintains a README (pointing at new package) and a stub in
chrome-launcher/index.jsto point to the realchrome-launcher. Also keepsmanual-chrome-launcherfor now so that thechrome-debugbinary andyarn chromestill work. We can switch over or remove some/all of these in the next major Lighthouse release