test(smokehouse): add TTFB smoke test #3310
Conversation
|
thanks @brendankenny! |
| @@ -32,6 +32,10 @@ module.exports = [ | |||
| 'consistently-interactive': { | |||
| score: '>=90', | |||
| }, | |||
| 'time-to-first-byte': { | |||
| // Can be flaky, so test float rawValue instead of boolean score | |||
There was a problem hiding this comment.
we can add a ?delay=650 or something to the main URL to force it to fail if we want to check the boolean score?
There was a problem hiding this comment.
do we prefer failure? either way we're only checking one execution path
There was a problem hiding this comment.
this does check that rawValue is a number and that it's less than 1000. I could tighten that up based on what passes on Travis, though
There was a problem hiding this comment.
I'm fine either way just wanted to bring it up since the comment suggests that it was trying to check the boolean but couldn't, at first I did misread this as score < 1000 though 😆
There was a problem hiding this comment.
Oh I see, yeah, the delay would push score firmly over to the fail side so we could test reliably.
I'm ok with the current approach rather than slowing it down (which would make me have to figure out new values for all the other numbers in this file :)
brendankenny
force-pushed
the
ttfb-smoke
branch
from
4323ea5 to
92ee62b
Compare
@wardpeet
followup to #2231