Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply small license header to last remaining files #3309

Merged
merged 2 commits into from
Sep 12, 2017
Merged

Apply small license header to last remaining files #3309

merged 2 commits into from
Sep 12, 2017

Conversation

paulirish
Copy link
Member

patrickhulce
patrickhulce suggested changes Sep 12, 2017
View reviewed changes
lighthouse-cli/test/smokehouse/byte-efficiency/run-tests.sh Outdated
@@ -13,4 +13,4 @@ exit_code=$?
# kill test servers
kill $(jobs -p)

exit "$exit_code"
exit 1; # "$exit_code"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems unintentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed. thx

brendankenny
brendankenny approved these changes Sep 12, 2017
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last remaining files

better be :P

@brendankenny brendankenny merged commit da9f789 into master Sep 12, 2017
@brendankenny brendankenny deleted the smallheaderfixes branch September 12, 2017 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce requested changes

@brendankenny brendankenny brendankenny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulirish @brendankenny @patrickhulce