launcher: mute any audio #3028
Merged
launcher: mute any audio #3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebidel
approved these changes
Aug 17, 2017
|
Is there a way to enable audio again via flags. I'd want headful mode to have audio. Edit: wrong project |
paulirish
added a commit
to GoogleChrome/chrome-launcher
that referenced
this pull request
Aug 29, 2017
|
I'm attempting to use chrome launcher to record a screengrab of a website and would like to include audio. As this flag is in the defaults, there appears to be no way to override the behaviour (short of forking the entire code). I guess the above comments suggest that it should never be used for audio.. Would it be possible to make this a non-default flag as an option that defaults to true? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
via puppeteer/puppeteer#350