report: draw metric lines over the screenshots. #2848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
reviewed
Aug 4, 2017
| .lh-timeline { | ||
| padding: 0; | ||
| padding-bottom: 0; | ||
| min-width: calc(var(--lh-filmstrip-thumbnail-width) * 10 + var(--default-padding) * 2); |
There was a problem hiding this comment.
:/ not a major fan of this one without something to put there
There was a problem hiding this comment.
going to leave alone the empty space on the right for now. After I add in the button to view trace i'll revisit this.
ebidel
reviewed
Aug 4, 2017
| animation-fill-mode: forwards; | ||
| } | ||
|
|
||
| @keyframes fadeIn { |
There was a problem hiding this comment.
Personal perf is to put definitions like @keyframes at the top of the file, but that's just me. Up to you.
ebidel
approved these changes
Aug 4, 2017
This reverts commit dbaf4e1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on discussion that lighthouse team members didn't know these things shared the same timescale. :)
lines only draw on hover: