Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hostname as parameter for GoogleChrome/lighthouse#2727 #2793

Closed
wants to merge 3 commits into from

Conversation

salvocanna
Copy link

Convert the parameter configs to object to make it more extensible and add the hostname parameter.
This is actually in conflict with #2728
Whichever makes more sense, as long as we can have a host param :)

Convert the parameter conf to object to make it more extensible
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@salvocanna
Copy link
Author

CLA: I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@paulirish
Copy link
Member

Did you confirm this works? I thought I recall remote-debugging-port only listening to localhost by default. 😕

@brendankenny
Copy link
Member

Closing in favor of #2728

@salvocanna please weigh in on that PR so we can make sure it meets everyone's needs 👍🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants