core(network): align headers end time with send when no data received #16044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Jun 5, 2024
| @@ -381,7 +381,7 @@ class NetworkRequest { | |||
| _recomputeTimesWithResourceTiming(timing) { | |||
| // Don't recompute times if the data is invalid. RequestTime should always be a thread timestamp. | |||
| // If we don't have receiveHeadersEnd, we really don't have more accurate data. | |||
| if (timing.requestTime === 0 || timing.receiveHeadersEnd === -1) return; | |||
| if (timing.requestTime === -1 || timing.receiveHeadersEnd === -1) return; | |||
There was a problem hiding this comment.
checking against 0 is a mistake given we have test records that start at 0. this caused roundtrip to fail.
connorjclark
commented
Jun 5, 2024
| @@ -587,7 +587,7 @@ describe('network recorder', function() { | |||
| localizedFailDescription: 'net::ERR_ABORTED', | |||
| rendererStartTime: 500, | |||
| networkRequestTime: 500, | |||
| responseHeadersEndTime: -1, | |||
| responseHeadersEndTime: 500, | |||
| networkEndTime: 501, | |||
There was a problem hiding this comment.
this value being -1 when rendererStartTime/networkRequestTime is set is no longer a valid state.
adamraine
approved these changes
Jun 5, 2024
connorjclark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies how our NetworkRequest sets
responseHeadersEndin the absence of actual network data received (ex: cached requests or data urls) to match what TraceEngine does. Instead of falling back to the CDP timestamp of the onResponse event, use the timestamp from the willSendRequest event.ref #15841