tests: update interactive test trace #16001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
May 14, 2024
| @@ -11,7 +11,7 @@ import {NetworkRecords} from '../../../../computed/network-records.js'; | |||
| import {readJson} from '../../../test-utils.js'; | |||
| import {NetworkRequest} from '../../../../lib/network-request.js'; | |||
|
|
|||
| const devtoolsLog = readJson('../../../fixtures/artifacts/progressive-app/devtoolslog.json', import.meta); | |||
| const devtoolsLog = readJson('../../../fixtures/traces/progressive-app-m60.devtools.log.json', import.meta); | |||
| const devtoolsLogWithRedirect = readJson('../../../fixtures/artifacts/redirect/devtoolslog.json', import.meta); | |||
There was a problem hiding this comment.
reverted on purpose. the tests are too tailored to the original trace. better to not modify.
connorjclark
changed the title
adamraine
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed the trace used in
computed/metrics/interactive-test.jsto be modern for trace engine. Required using provided throttling otherwise got a NO_TTI_CPU_IDLE_PERIOD error.ref #15841