-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: create writeFile destination if necessary #15990
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… they don't exist Signed-off-by: Nathanael Bracy <[email protected]>
servusdei2018
changed the title
fix(cli/printer.js): ensure writeFile creates filePath directories if they don't exist
cli(printer.js): ensure writeFile creates filePath directories if they don't exist
May 10, 2024
servusdei2018
changed the title
cli(printer.js): ensure writeFile creates filePath directories if they don't exist
cli: ensure writeFile creates filePath directories if they don't exist
May 10, 2024
adamraine
reviewed
Nov 13, 2024
Signed-off-by: Nathanael Bracy <[email protected]>
Signed-off-by: Nathanael Bracy <[email protected]>
Hmm looks like the "throws for invalid paths" test case is failing because This updated test should cover the new logic: it('throws for invalid paths', () => {
const path = '//#@.json';
const report = JSON.stringify(sampleResults);
return assert.rejects(Printer.write(report, 'html', path));
}); |
adamraine
requested changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the yarn.lock and package-lock.json changes
adamraine
approved these changes
Nov 14, 2024
adamraine
changed the title
cli: ensure writeFile creates filePath directories if they don't exist
cli: create writeFile destination if necessary
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a fix for
writeFile
. The function currently assumes that the directories leading to the specifiedfilePath
exist, but this PR ensures that they exist.Related Issues/PRs
No related issues or PRs.