Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: change connectionId from string to number #15983

Merged
merged 1 commit into from
May 2, 2024
Merged

misc: change connectionId from string to number #15983

merged 1 commit into from
May 2, 2024

Conversation

connorjclark
Copy link
Collaborator

No description provided.

@connorjclark connorjclark requested a review from a team as a code owner May 1, 2024 23:26
@connorjclark connorjclark requested review from adamraine and removed request for a team May 1, 2024 23:26
connorjclark
connorjclark commented May 2, 2024
View reviewed changes
core/test/fixtures/networkRecords-mix.json
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

olllllld

paulirish
paulirish approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can confirm this is a number in both CDP and trace representations.

@connorjclark connorjclark merged commit 369979f into main May 2, 2024
25 of 27 checks passed
@connorjclark connorjclark deleted the connection-num branch May 2, 2024 20:27
@alcance alcance mentioned this pull request Jul 10, 2024
Open
@jones58 jones58 mentioned this pull request Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

@adamraine adamraine Awaiting requested review from adamraine adamraine is a code owner automatically assigned from GoogleChrome/lighthouse-hackers

Assignees

@adamraine adamraine

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@connorjclark @paulirish @adamraine @devtools-bot