Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: remove plugins audit #15928

Merged
merged 8 commits into from
Apr 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/test/fixtures/dobetterweb/dbw_tester.html
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@

<!-- Various sites like to assign HTMLElements a custom `matches` property. See issue #5934 -->

<!-- EmbeddedContent will process these elements -->
<!-- Was for deprecated plugins audit, keeping them so smoke expectations don't change (e.g. dom-size) -->
<object id="5934a"></object>
<object id="5934b"></object>

Expand Down
20 changes: 0 additions & 20 deletions cli/test/fixtures/seo/seo-failure-cases.html
Original file line number Diff line number Diff line change
Expand Up @@ -56,25 +56,5 @@ <h2>Anchor text</h2>
<script>
document.querySelector('.link-parent').addEventListener('click', () => {});
</script>

<!-- FAIL(plugins): java applet on page -->
<applet code=HelloWorld.class width="200" height="200" id='applet'>
Your browser does not support the <code>applet</code> tag.
</applet>

<!-- FAIL(plugins): flash content on page -->
<object classid="clsid:d27cdb6e-ae6d-11cf-96b8-444553540000" width="590" height="90" id="adobe-embed" align="middle">
<param name="movie" value="movie_name.swf"/>
<!--[if !IE]>-->
<object type="application/x-shockwave-flash" data="movie_name.swf" width="590" height="90">
<param name="movie" value="movie_name.swf"/>
<!--<![endif]-->
<a href="http://www.adobe.com/go/getflash">
<img src="http://www.adobe.com/images/shared/download_buttons/get_flash_player.gif" alt="Get Adobe Flash player"/>
</a>
<!--[if !IE]>-->
</object>
<!--<![endif]-->
</object>
</body>
</html>
2 changes: 0 additions & 2 deletions cli/test/fixtures/seo/seo-tester.html
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@ <h6>2</h6>
</script>
<!-- override global URL - bug #5701 -->
<script>URL = '';</script>
<!-- PASS(plugins): external content does not require java, flash or silverlight -->
<object data="test.pdf" type="application/pdf" width="300" height="200"></object>

<!-- PASS(crawlable-anchors): Link with a relative path -->
<a href="/pass">Some link</a>
Expand Down
8 changes: 0 additions & 8 deletions cli/test/smokehouse/test-definitions/seo-failing.js
Original file line number Diff line number Diff line change
Expand Up @@ -98,14 +98,6 @@ const expectations = {
},
},
},
'plugins': {
score: 0,
details: {
items: {
length: 3,
},
},
},
'canonical': {
score: 0,
explanation: 'Multiple conflicting URLs (https://example.com/other, https://example.com/)',
Expand Down
3 changes: 0 additions & 3 deletions cli/test/smokehouse/test-definitions/seo-passing.js
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,6 @@ const expectations = {
'hreflang': {
score: 1,
},
'plugins': {
score: 1,
},
'canonical': {
score: 1,
},
Expand Down
3 changes: 0 additions & 3 deletions cli/test/smokehouse/test-definitions/seo-status-403.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,6 @@ const expectations = {
'hreflang': {
score: null,
},
'plugins': {
score: null,
},
'canonical': {
score: null,
},
Expand Down
150 changes: 0 additions & 150 deletions core/audits/seo/plugins.js

This file was deleted.

3 changes: 0 additions & 3 deletions core/config/default-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ const defaultConfig = {
{id: 'CSSUsage', gatherer: 'css-usage'},
{id: 'Doctype', gatherer: 'dobetterweb/doctype'},
{id: 'DOMStats', gatherer: 'dobetterweb/domstats'},
{id: 'EmbeddedContent', gatherer: 'seo/embedded-content'},
{id: 'FontSize', gatherer: 'seo/font-size'},
{id: 'Inputs', gatherer: 'inputs'},
{id: 'IFrameElements', gatherer: 'iframe-elements'},
Expand Down Expand Up @@ -329,7 +328,6 @@ const defaultConfig = {
'seo/is-crawlable',
'seo/robots-txt',
'seo/hreflang',
'seo/plugins',
'seo/canonical',
'seo/manual/structured-data',
'work-during-interaction',
Expand Down Expand Up @@ -615,7 +613,6 @@ const defaultConfig = {
{id: 'hreflang', weight: 1, group: 'seo-content'},
{id: 'canonical', weight: 1, group: 'seo-content'},
{id: 'font-size', weight: 1, group: 'seo-mobile'},
{id: 'plugins', weight: 1, group: 'seo-content'},
// Manual audits
{id: 'structured-data', weight: 0},
],
Expand Down
63 changes: 0 additions & 63 deletions core/gather/gatherers/seo/embedded-content.js

This file was deleted.

Loading
Loading