Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: remove tap-targets and show target-size in a11y #15906

Merged
merged 4 commits into from
Apr 1, 2024
Merged

core: remove tap-targets and show target-size in a11y #15906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c8a9db
core: replace `tap-targets` with `target-size` from Axe
adamraine Apr 1, 2024
305e8cc
tests
adamraine Apr 1, 2024
2aedf24
dbw
adamraine Apr 1, 2024
0e42203
ope
adamraine Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions cli/test/fixtures/dobetterweb/dbw_tester.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,16 +242,6 @@ <h2 id="toppy" style="background-image:url('');">Do better web tester page</h2>
<!-- FAIL(efficient-animated-content): animated gif found -->
<img src="lighthouse-rotating.gif" width="811" height="462">

<!-- FAIL(tap-targets): buttons too close together -->
<style>
.small-button {
display: block;
width: 200px;
}
</style>
<button class="small-button">Do something</button>
<button class="small-button">Do something else</button>

<!-- Some websites overwrite the original Error object. The captureJSCallUsage function
relies on the native Error object and prepareStackTrace from V8. When overwriting the stack
property the e.stack inside the gatherer won't be in the correct format
Expand Down
207 changes: 0 additions & 207 deletions cli/test/fixtures/seo/seo-tap-targets.html
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions cli/test/smokehouse/core-tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ import screenshot from './test-definitions/screenshot.js';
import seoFailing from './test-definitions/seo-failing.js';
import seoPassing from './test-definitions/seo-passing.js';
import seoStatus403 from './test-definitions/seo-status-403.js';
import seoTapTargets from './test-definitions/seo-tap-targets.js';
import serviceWorkerReloaded from './test-definitions/service-worker-reloaded.js';
import shiftAttribution from './test-definitions/shift-attribution.js';
import sourceMaps from './test-definitions/source-maps.js';
Expand Down Expand Up @@ -126,7 +125,6 @@ const smokeTests = [
seoFailing,
seoPassing,
seoStatus403,
seoTapTargets,
Copy link
Member Author

@adamraine adamraine Apr 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a decent amount of tap targets coverage in this test, but I don't think we need to verify the target size logic since it's coming from axe. There is already a small target-size check in the a11y smoke test.

serviceWorkerReloaded,
shiftAttribution,
sourceMaps,
Expand Down
4 changes: 2 additions & 2 deletions cli/test/smokehouse/test-definitions/dobetterweb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,15 +442,15 @@ const expectations = {
},
'dom-size': {
score: 1,
numericValue: 154,
numericValue: 151,
details: {
items: [
{
statistic: 'Total DOM Elements',
value: {
type: 'numeric',
granularity: 1,
value: 154,
value: 151,
},
},
{
Expand Down
Loading
Loading