Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(installable-manifest): add manifest-parsing-or-network-error #15849

Merged
merged 2 commits into from
Mar 5, 2024
Merged

core(installable-manifest): add manifest-parsing-or-network-error #15849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3cb318
core(installable-manifest): add `manifest-parsing-or-network-error`
adamraine Mar 4, 2024
b5c0ae7
sample
adamraine Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/audits/installable-manifest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ const UIStrings = {
'manifest-display-not-supported': 'Manifest `display` property must be one of `standalone`, `fullscreen`, or `minimal-ui`',
/** Error message explaining that the manifest could not be fetched, might be empty, or could not be parsed. */
'manifest-empty': `Manifest could not be fetched, is empty, or could not be parsed`,
/** Error message explaining that the manifest could not be fetched, might be empty, or could not be parsed. */
'manifest-parsing-or-network-error': 'Manifest could not be fetched, is empty, or could not be parsed',
/**
* @description Error message explaining that the manifest does not contain a suitable icon.
* @example {192} value0
Expand Down
3 changes: 3 additions & 0 deletions shared/localization/locales/en-US.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions shared/localization/locales/en-XL.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion third-party/chromium-synchronization/installability-errors-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@ Array [
"in-incognito",
"manifest-display-not-supported",
"manifest-display-override-not-supported",
"manifest-empty",
"manifest-location-changed",
"manifest-missing-name-or-short-name",
"manifest-missing-suitable-icon",
"manifest-parsing-or-network-error",
"no-acceptable-icon",
"no-icon-available",
"no-id-specified",
Expand Down
Loading