Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(dbw): revert expectations for unload handler removal #15802

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

adamraine
Copy link
Member

@adamraine adamraine commented Feb 5, 2024

This reverts commit 3d27df1 / PR #15765

I guess Chrome backed off the unload handler removal (for now). I also verified this works on Chrome beta (M122).

This PR also updates the version for ScriptElements expectations from #15601 which is another smoke failure that appeared recently.

@adamraine adamraine requested a review from a team as a code owner February 5, 2024 17:39
@adamraine adamraine requested review from connorjclark and removed request for a team February 5, 2024 17:39
Copy link

vercel bot commented Feb 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lighthouse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2024 6:01pm

@adamraine adamraine merged commit 45e04ce into main Feb 5, 2024
28 checks passed
@adamraine adamraine deleted the revert-15765-unload-handlers-gone branch February 5, 2024 21:53
@connorjclark
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants