misc: update web.dev URLs #15534
misc: update web.dev URLs #15534
Conversation
shared/localization/locales/ca.json
Outdated
| @@ -639,7 +639,7 @@ | |||
| "message": "Utilitza formats de vídeo per al contingut animat" | |||
| }, | |||
| "core/audits/byte-efficiency/legacy-javascript.js | description": { | |||
| "message": "Els polyfills i les transformacions permeten als navegadors heretats fer servir funcions de JavaScript noves. No obstant això, molts no són necessaris per als navegadors moderns. Per al teu JavaScript empaquetat, adopta una estratègia de desenvolupament de scripts moderna utilitzant la detecció de la funció mòdul / no mòdul per reduir la quantitat de codi enviat als navegadors moderns, mantenint al mateix temps la compatibilitat amb els navegadors heretats. [Informació sobre com pots utilitzar el JavaScript modern](https://web.dev/publish-modern-javascript/)" | |||
| "message": "Els polyfills i les transformacions permeten als navegadors heretats fer servir funcions de JavaScript noves. No obstant això, molts no són necessaris per als navegadors moderns. Per al teu JavaScript empaquetat, adopta una estratègia de desenvolupament de scripts moderna utilitzant la detecció de la funció mòdul / no mòdul per reduir la quantitat de codi enviat als navegadors moderns, mantenint al mateix temps la compatibilitat amb els navegadors heretats. [Informació sobre com pots utilitzar el JavaScript modern](https://web.dev/articles/publish-modern-javascript)" | |||
There was a problem hiding this comment.
i18n string changes need to go through the translator pipeline, but I imagine this would be the result anyway. Did you run yarn update:sample-json?
There was a problem hiding this comment.
No I didn't. When I do that it reverts my changes. Am I missing a step I need to do first? I tried yarn build-all first but no diff.
There was a problem hiding this comment.
I think reverting your changes makes sense. Most of these files (with the exception of en-US & en-XL) we get from the translator engine in g3. So we don't want to edit these files directly.
After this PR lands we can upload the new i18n strings to g3. Then once the new strings go through the translator pipeline we will pull them in before the next release.
There was a problem hiding this comment.
So revert everything in locales directory but leave all the .js changes?
There was a problem hiding this comment.
OK did what @brendankenny suggested:
FWIW you'll probably make your life a lot easier backing out the shared/localization/locales/* and sample-flow-result.json/sample_v2.json changes, run yarn update:sample-json, then let the localization pipeline take care of the rest
And that worked this time. Only the en-US and en-XL ones changed.
|
Looking more promising now @adamraine and @brendankenny - all tests now passing. |
Summary
Web.dev moved infrastructure this week and the URL formats have changed.
In most cases there's a redirect in place (though not for the third one sadly), but let's update the URLs to avoid this redirect.
This also updates some URLs that redirect to developer.chrome.com or dequeuniversity.com to go there directly.
Avoid redirects and fix anchor ids.
Related Issues/PRs