Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(installable-manifest): use monospace for technical terms in strings #15513

Merged
merged 1 commit into from
Oct 3, 2023
Merged

core(installable-manifest): use monospace for technical terms in strings #15513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/audits/installable-manifest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ const UIStrings = {
/** Error message explaining that the provided manifest URL is invalid. */
'start-url-not-valid': `Manifest start URL is not valid`,
/** Error message explaining that the provided manifest does not contain a name or short_name field. */
'manifest-missing-name-or-short-name': `Manifest does not contain a 'name' or 'short_name' field`,
'manifest-missing-name-or-short-name': 'Manifest does not contain a `name` or `short_name` field',
/** Error message explaining that the manifest display property must be one of 'standalone', 'fullscreen', or 'minimal-ui'. */
'manifest-display-not-supported': `Manifest 'display' property must be one of 'standalone', 'fullscreen', or 'minimal-ui'`,
'manifest-display-not-supported': 'Manifest `display` property must be one of `standalone`, `fullscreen`, or `minimal-ui`',
Copy link
Collaborator Author

@connorjclark connorjclark Oct 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a manifest file is JSON, so no need to wrap with ' to disambiguate like the other PR

/** Error message explaining that the manifest could not be fetched, might be empty, or could not be parsed. */
'manifest-empty': `Manifest could not be fetched, is empty, or could not be parsed`,
/**
Expand Down
2 changes: 1 addition & 1 deletion core/test/audits/installable-manifest-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ describe('PWA: webapp install banner audit', () => {
return InstallableManifestAudit.audit(artifacts, context).then(result => {
assert.strictEqual(result.score, 0);
const items = result.details.items;
expect(items[0].reason).toBeDisplayString(/does not contain a 'name'/);
expect(items[0].reason).toBeDisplayString(/does not contain a `name`/);
});
});

Expand Down
4 changes: 2 additions & 2 deletions shared/localization/locales/en-US.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions shared/localization/locales/en-XL.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading