Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: re-order manual audits and expand when audits pass #15310

Merged
merged 7 commits into from
Jul 28, 2023
Merged

report: re-order manual audits and expand when audits pass #15310

merged 7 commits into from
Jul 28, 2023

Conversation

jazyan
Copy link
Collaborator

@jazyan jazyan commented Jul 26, 2023 •
edited
Loading

This PR aims to make it more obvious that there are possibly still a11y issues outside of what Lighthouse can automatically test. And that this applies even if the page scores a 100 in a11y.

Included changes:

  • Expand manual audits upon scoring 100 in accessibility.
    • Verified locally that this expansion happens only for a11y score = 100 (no expansion in SEO, no expansion when a11y score != 100)
  • Reorder manual audits to be sorted in descending approachability.
  • Update accessibility category description.

@jazyan jazyan requested a review from a team as a code owner July 26, 2023 21:13
@jazyan jazyan requested review from brendankenny and removed request for a team July 26, 2023 21:13
@jazyan jazyan marked this pull request as draft July 26, 2023 21:20
@jazyan jazyan changed the title wip: expand manual audits on accessibility score 100 core(a11y): re-order manual audits and expand on a11y score 100 Jul 27, 2023
@jazyan jazyan marked this pull request as ready for review July 27, 2023 14:36
jazyan
jazyan commented Jul 27, 2023
View reviewed changes
core/config/default-config.js Outdated Show resolved Hide resolved
report/renderer/category-renderer.js Outdated Show resolved Hide resolved
adamraine
adamraine reviewed Jul 27, 2023
View reviewed changes
report/renderer/category-renderer.js Outdated Show resolved Hide resolved
report/renderer/category-renderer.js Outdated Show resolved Hide resolved
report/renderer/category-renderer.js Outdated Show resolved Hide resolved
core/config/default-config.js Outdated Show resolved Hide resolved
brendankenny
brendankenny approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a major improvement for the accessibility section and takes the manual audits from basically vestigial to essential. Looks great!

report/renderer/category-renderer.js Show resolved Hide resolved
adamraine
adamraine approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 to test case

@adamraine adamraine changed the title core(a11y): re-order manual audits and expand on a11y score 100 core(a11y): re-order manual audits and expand when all audits pass Jul 28, 2023
@adamraine adamraine changed the title core(a11y): re-order manual audits and expand when all audits pass core(a11y): re-order manual audits and expand when audits pass Jul 28, 2023
@adamraine adamraine changed the title core(a11y): re-order manual audits and expand when audits pass report: re-order manual audits and expand when audits pass Jul 28, 2023
@jazyan jazyan merged commit 113bd76 into main Jul 28, 2023
24 checks passed
@jazyan jazyan deleted the expand-a11y-manual branch July 28, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamraine adamraine adamraine approved these changes

@connorjclark connorjclark connorjclark left review comments

@brendankenny brendankenny brendankenny approved these changes

Assignees

@brendankenny brendankenny

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jazyan @brendankenny @connorjclark @adamraine @devtools-bot