misc: remove residual references to legacy #15292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
Jul 20, 2023
| const params = new URLSearchParams(location.search); | ||
|
|
||
| if (location.search === '' || params.has('deprecations')) { | ||
| window.webkitStorageInfo.PERSISTENT; // FAIL(deprecations) |
There was a problem hiding this comment.
Drive-by: webkitStorageInfo was removed (no longer just a deprecation) which was causing an extra error to appear in errors-in-console. We were not catching this before because we were not asserting a specific length for the number of errors before, but we are in this PR.
We had a note to remove when M110 hit stable as well.
adamraine
commented
Jul 20, 2023
| */ | ||
| function createMockSendCommandFn(options) { |
There was a problem hiding this comment.
useSessionId always needs to be false now that we removed the legacy runner, so we can just get rid of the options entirely
connorjclark
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically just searched for keywords like "legacy" and "FR" and "fraggle" to find all the places where we still reference legacy mode or refer to user flows with "Fraggle Rock". Most of them are in tests.
Updating docs will be done in a separate PR.
#15060