Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: import #15243

Merged
merged 1 commit into from
Jul 10, 2023
Merged

i18n: import #15243

merged 1 commit into from
Jul 10, 2023

Conversation

adamraine
Copy link
Member

No description provided.

@adamraine adamraine requested a review from a team as a code owner July 10, 2023 22:11
@adamraine adamraine requested review from brendankenny and removed request for a team July 10, 2023 22:11
"message": "Permission for the notification API may no longer be requested from a cross-origin iframe. You should consider requesting permission from a top-level frame or opening a new window instead."
},
"core/lib/deprecations-strings.js | ObsoleteCreateImageBitmapImageOrientationNone": {
"message": "Option `imageOrientation: 'none'` in createImageBitmap is deprecated. Please use createImageBitmap with option \\{imageOrientation: 'from-image'\\} instead."
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the translations (including this one) did not have the necessary \\ in them which was breaking yarn i18n:collect. This appears to be a mistake so I took the liberty of adding them.

@adamraine
Copy link
Member Author

Here is a quick diff of the changes I had to make:

diff --git a/shared/localization/locales/en-GB.json b/shared/localization/locales/en-GB.json
index d694f2885..d4664d3bf 100644
--- a/shared/localization/locales/en-GB.json
+++ b/shared/localization/locales/en-GB.json
@@ -2277,7 +2277,7 @@
     "message": "Permission for the notification API may no longer be requested from a cross-origin iframe. You should consider requesting permission from a top-level frame or opening a new window instead."
   },
   "core/lib/deprecations-strings.js | ObsoleteCreateImageBitmapImageOrientationNone": {
-    "message": "Option `imageOrientation: 'none'` in createImageBitmap is deprecated. Please use createImageBitmap with option \\{imageOrientation: 'from-image'\\} instead."
+    "message": "Option `imageOrientation: 'none'` in createImageBitmap is deprecated. Please use createImageBitmap with option {imageOrientation: 'from-image'} instead."
   },
   "core/lib/deprecations-strings.js | ObsoleteWebRtcCipherSuite": {
     "message": "Your partner is negotiating an obsolete (D)TLS version. Please check with your partner to have this fixed."
diff --git a/shared/localization/locales/he.json b/shared/localization/locales/he.json
index d6eb56855..777fee983 100644
--- a/shared/localization/locales/he.json
+++ b/shared/localization/locales/he.json
@@ -2277,7 +2277,7 @@
     "message": "לא ניתן יותר לבקש הרשאה ל-Notification API מ-iframe ממקורות שונים. במקום זאת, כדאי לבקש הרשאה ממסגרת ברמה עליונה או לפתוח חלון חדש."
   },
   "core/lib/deprecations-strings.js | ObsoleteCreateImageBitmapImageOrientationNone": {
-    "message": "האפשרות `imageOrientation: 'none'` ב-createImageBitmap הוצאה משימוש. במקומה צריך להשתמש ב-createImageBitmap ולהוסיף את האפשרות \\{imageOrientation: 'from-image'\\}."
+    "message": "האפשרות `imageOrientation: 'none'` ב-createImageBitmap הוצאה משימוש. במקומה צריך להשתמש ב-createImageBitmap ולהוסיף את האפשרות \\{imageOrientation: 'from-image'\\}."
   },
   "core/lib/deprecations-strings.js | ObsoleteWebRtcCipherSuite": {
     "message": "השותף שלך מנהל משא ומתן על גרסת (D)TLS מיושנת. עליך לפנות לשותף שלך כדי לתקן זאת."
diff --git a/shared/localization/locales/hr.json b/shared/localization/locales/hr.json
index 7b42c7980..09ddd12be 100644
--- a/shared/localization/locales/hr.json
+++ b/shared/localization/locales/hr.json
@@ -2277,7 +2277,7 @@
     "message": "Možda se više neće tražiti dopuštenje za Notification API iz iframea različitih izvora. Trebali biste razmisliti o traženju dopuštenja okvira najviše razine ili o otvaranju novog prozora."
   },
   "core/lib/deprecations-strings.js | ObsoleteCreateImageBitmapImageOrientationNone": {
-    "message": "Opcija `imageOrientation: 'none'` u stavci CreateImageBitmapa je obustavljena. Umjesto nje upotrijebite oznaku createImageBitmap s opcijom \\{imageOrientation: 'from-image'\\}."
+    "message": "Opcija `imageOrientation: 'none'` u stavci CreateImageBitmapa je obustavljena. Umjesto nje upotrijebite oznaku createImageBitmap s opcijom {imageOrientation: 'from-image'\\}."
   },
   "core/lib/deprecations-strings.js | ObsoleteWebRtcCipherSuite": {
     "message": "Vaš partner pregovara o zastarjeloj verziji (D)TLS-a. Provjerite s partnerom kako biste to ispravili."
diff --git a/shared/localization/locales/sk.json b/shared/localization/locales/sk.json
index 54a00b67e..7a87fcfa0 100644
--- a/shared/localization/locales/sk.json
+++ b/shared/localization/locales/sk.json
@@ -2277,7 +2277,7 @@
     "message": "Povolenie pre rozhranie Notification API už nie je možné požadovať z prvku iframe od iných zdrojov. Namiesto toho by ste mali zvážiť požadovanie povolenia z rámu najvyššej úrovne alebo otvorenie nového okna."
   },
   "core/lib/deprecations-strings.js | ObsoleteCreateImageBitmapImageOrientationNone": {
-    "message": "Podpora možnosti `imageOrientation: 'none'` v nástroji createImageBitmap bola ukončená. Namiesto nej použite nástroj createImageBitmap pomocou možnosti \\{imageOrientation: 'from-image'\\}."
+    "message": "Podpora možnosti `imageOrientation: 'none'` v nástroji createImageBitmap bola ukončená. Namiesto nej použite nástroj createImageBitmap pomocou možnosti {imageOrientation: 'from-image'}."
   },
   "core/lib/deprecations-strings.js | ObsoleteWebRtcCipherSuite": {
     "message": "Váš partner používa zastaranú verziu (D)TLS. Požiadajte ho, aby tento problém odstránil."
diff --git a/shared/localization/locales/te.json b/shared/localization/locales/te.json
index 72e47e81f..297b9b97e 100644
...skipping...
+    "message": "Opcija `imageOrientation: 'none'` u stavci CreateImageBitmapa je obustavljena. Umjesto nje upotrijebite oznaku createImageBitmap s opcijom {imageOrientation: 'from-image'\\}."
   },
   "core/lib/deprecations-strings.js | ObsoleteWebRtcCipherSuite": {
     "message": "Vaš partner pregovara o zastarjeloj verziji (D)TLS-a. Provjerite s partnerom kako biste to ispravili."
diff --git a/shared/localization/locales/sk.json b/shared/localization/locales/sk.json
index 54a00b67e..7a87fcfa0 100644
--- a/shared/localization/locales/sk.json
+++ b/shared/localization/locales/sk.json
@@ -2277,7 +2277,7 @@
     "message": "Povolenie pre rozhranie Notification API už nie je možné požadovať z prvku iframe od iných zdrojov. Namiesto toho by ste mali zvážiť požadovanie povolenia z rámu najvyššej úrovne alebo otvorenie nového okna."
   },
   "core/lib/deprecations-strings.js | ObsoleteCreateImageBitmapImageOrientationNone": {
-    "message": "Podpora možnosti `imageOrientation: 'none'` v nástroji createImageBitmap bola ukončená. Namiesto nej použite nástroj createImageBitmap pomocou možnosti \\{imageOrientation: 'from-image'\\}."
+    "message": "Podpora možnosti `imageOrientation: 'none'` v nástroji createImageBitmap bola ukončená. Namiesto nej použite nástroj createImageBitmap pomocou možnosti {imageOrientation: 'from-image'}."
   },
   "core/lib/deprecations-strings.js | ObsoleteWebRtcCipherSuite": {
     "message": "Váš partner používa zastaranú verziu (D)TLS. Požiadajte ho, aby tento problém odstránil."
diff --git a/shared/localization/locales/te.json b/shared/localization/locales/te.json
index 72e47e81f..297b9b97e 100644
--- a/shared/localization/locales/te.json
+++ b/shared/localization/locales/te.json
@@ -2277,7 +2277,7 @@
     "message": "నోటిఫికేషన్ APIకి అనుమతిని ఇకపై క్రాస్-ఆరిజిన్ iframe నుండి రిక్వెస్ట్ చేయడం కుదరకపోవచ్చు. టాప్-లెవెల్ ఫ్రేమ్ నుండి అనుమతిని రిక్వెస్ట్ చేయడాన్ని, లేదా అందుకు బదులుగా కొత్త విండోను తెరవడాన్ని మీరు పరిశీలించాలి."
   },
   "core/lib/deprecations-strings.js | ObsoleteCreateImageBitmapImageOrientationNone": {
-    "message": "createImageBitmap‌లోని `imageOrientation: 'none'` ఆప్షన్ విస్మరించబడింది. దయచేసి బదులుగా \\{imageOrientation: 'from-image'\\} ఆప్షన్‌తో createImageBitmap‌ను ఉపయోగించండి."
+    "message": "createImageBitmap‌లోని `imageOrientation: 'none'` ఆప్షన్ విస్మరించబడింది. దయచేసి బదులుగా {imageOrientation: 'from-image'} ఆప్షన్‌తో createImageBitmap‌ను ఉపయోగించండి."
   },
   "core/lib/deprecations-strings.js | ObsoleteWebRtcCipherSuite": {
     "message": "మీ పార్ట్‌నర్ వాడుకలో లేని (D)TLS వెర్షన్‌ను నెగోషియేట్ చేస్తున్నారు. దీన్ని పరిష్కరించడం కోసం దయచేసి మీ పార్ట్‌నర్‌ను సంప్రదించండి."
diff --git a/shared/localization/locales/zh-HK.json b/shared/localization/locales/zh-HK.json
index fedb4a770..313d33467 100644
--- a/shared/localization/locales/zh-HK.json
+++ b/shared/localization/locales/zh-HK.json
@@ -2277,7 +2277,7 @@
     "message": "系統可能無法再透過跨來源 iframe 要求 Notification API。請考慮透過頂層頁框要求權限,或改為開啟新視窗。"
   },
   "core/lib/deprecations-strings.js | ObsoleteCreateImageBitmapImageOrientationNone": {
-    "message": "createImageBitmap 中的 `imageOrientation: 'none'` 選項已淘汰。使用 createImageBitmap 時請改用 \\{imageOrientation: 'from-image'\\} 選項。"
+    "message": "createImageBitmap 中的 `imageOrientation: 'none'` 選項已淘汰。使用 createImageBitmap 時請改用 {imageOrientation: 'from-image'} 選項。"
   },
   "core/lib/deprecations-strings.js | ObsoleteWebRtcCipherSuite": {
     "message": "您的合作夥伴正在交涉已過時的傳輸層安全標準 (TLS)/DTLS 版本。請向您的合作夥伴查詢,以便修正問題。"
diff --git a/shared/localization/locales/zh-TW.json b/shared/localization/locales/zh-TW.json
index fedac3301..bbcfdcb2c 100644
--- a/shared/localization/locales/zh-TW.json
+++ b/shared/localization/locales/zh-TW.json
@@ -2277,7 +2277,7 @@
     "message": "系統已不再允許透過跨來源 iframe 要求 Notification API 的權限。請考慮透過頂層頁框要求權限,或改為開啟新視窗。"
   },
   "core/lib/deprecations-strings.js | ObsoleteCreateImageBitmapImageOrientationNone": {
-    "message": "createImageBitmap 中的 `imageOrientation: 'none'` 選項已淘汰,使用 createImageBitmap 時請改用 \\{imageOrientation: 'from-image'\\} 選項。"
+    "message": "createImageBitmap 中的 `imageOrientation: 'none'` 選項已淘汰,使用 createImageBitmap 時請改用 {imageOrientation: 'from-image'} 選項。"
   },
   "core/lib/deprecations-strings.js | ObsoleteWebRtcCipherSuite": {
     "message": "你的合作夥伴正在交涉已過時的 TLS/DTLS 版本。請洽詢你的合作夥伴,請對方解決這個問題。"

@adamraine
Copy link
Member Author

b/290679361 opened

@adamraine adamraine merged commit 6b6afaa into main Jul 10, 2023
@adamraine adamraine deleted the i18n_10.4 branch July 10, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants