New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(config): add more validation from legacy #15211

Merged

adamraine merged 1 commit into main from config-more-validation

Jul 6, 2023

Member

adamraine commented Jun 29, 2023

Follow up to #15209

Adds some validation that it is the legacy config but not the new one.

skipAudits/onlyAudits is pretty straightforward, we just never added a check for this
Duplicate artifact id checks is new. In legacy config, we would dedup gatherers but in the new config it's allowed to use the same gatherer for two different artifacts. This PR just verifies that the artifact ids don't overlap.


          core(config): add more validation from legacy

cae2794

adamraine requested a review from a team as a code owner

June 29, 2023 01:13

adamraine requested review from connorjclark and removed request for a team

June 29, 2023 01:13

connorjclark approved these changes

View reviewed changes

adamraine merged commit b7b0fa2 into main

adamraine deleted the config-more-validation branch

July 6, 2023 18:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet