report: use fixed position for hidden radios #15181
Conversation
|
Do we know why this happens? Should we try to cherrypick the fix to 116 / 115? |
Talked offline about this. Still not 100% sure on the root cause and may need to get help from DT rendering folks since this only happens within DT. |
The typical approach is this fairly nasty looking https://github.com/twbs/bootstrap/blob/v5.0.2/scss/mixins/_visually-hidden.scss#L3-L18 |
I took a look at similar solutions, however it was the |
The affected code is minified and difficult to review, but the only change made was switching the position of some elements to `fixed`: GoogleChrome/lighthouse#15181 It is still unkown why `absolute` positioning caused this bug, but this CL should fix the symptoms until the root cause is found. Bug: 1439785 Change-Id: I04caee5e78d4c8257e4e4152e995f2c448fd0c34 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4633481 Commit-Queue: Connor Clark <[email protected]> Commit-Queue: Adam Raine <[email protected]> Reviewed-by: Connor Clark <[email protected]>
The affected code is minified and difficult to review, but the only change made was switching the position of some elements to `fixed`: GoogleChrome/lighthouse#15181 It is still unkown why `absolute` positioning caused this bug, but this CL should fix the symptoms until the root cause is found. Bug: 1439785 Change-Id: I04caee5e78d4c8257e4e4152e995f2c448fd0c34 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4633481 Commit-Queue: Connor Clark <[email protected]> Commit-Queue: Adam Raine <[email protected]> Reviewed-by: Connor Clark <[email protected]> (cherry picked from commit e4c1157) Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4681007
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=1439785
The absolute positioning of these radios caused the report rendering to bug out. Would be nice if there was a less hacky way to hide visually but still allow screen readers to use.