Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(cumulative-layout-shift): remove totalCumulativeLayoutShift #15122

Merged
merged 5 commits into from
Jun 12, 2023
Merged

core(cumulative-layout-shift): remove totalCumulativeLayoutShift #15122

merged 5 commits into from
Jun 12, 2023

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented May 30, 2023 •
edited
Loading

This CLS variant was only around for debugdata, but it's been two years since it was relevant.

@connorjclark connorjclark requested a review from a team as a code owner May 30, 2023 22:15
@connorjclark connorjclark requested review from adamraine, paulirish and a team and removed request for a team May 30, 2023 22:15
@brendankenny
Copy link
Member

brendankenny commented Jun 9, 2023 •
edited
Loading

totalCumulativeLayoutShift is long gone, so that seems fine, but cumulativeLayoutShiftMainFrame is still quite relevant in debug data (or metrics.js, really). With rare exceptions that's the CLS all RUM tools measure, for instance.

@connorjclark connorjclark changed the title core(cumulative-layout-shift): remove old cls core(cumulative-layout-shift): remove totalCumulativeLayoutShift Jun 9, 2023
@connorjclark connorjclark merged commit 0464a56 into main Jun 12, 2023
@connorjclark connorjclark deleted the rm-old-cls branch June 12, 2023 20:00
@adamraine adamraine mentioned this pull request Jul 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

@adamraine adamraine Awaiting requested review from adamraine adamraine is a code owner automatically assigned from GoogleChrome/lighthouse-hackers

Assignees

@adamraine adamraine

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@connorjclark @brendankenny @paulirish @adamraine @devtools-bot