core(network-analyzer): fix num of roundtrips for h3 estimates #15102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
reviewed
May 22, 2023
| @@ -194,7 +194,8 @@ class NetworkAnalyzer { | |||
|
|
|||
| // Assume everything before sendStart was just DNS + (SSL)? + TCP handshake | |||
| // 1 RT for DNS, 1 RT (maybe) for SSL, 1 RT for TCP | |||
| let roundTrips = 2; | |||
| let roundTrips = 1; | |||
| if (!record.protocol.startsWith('h3')) roundTrips += 1; // TCP | |||
There was a problem hiding this comment.
We should add this logic to TTFB as well.
WDYT about adding some kind of getRoundTripCount helper function to NetworkRequest so that we don't have to maintain this in 3 different places?
There was a problem hiding this comment.
It's a bit more complicated than first glance to share this code, since the analyzer has its own concept of "is this connection reused?". I can try in a followup.
adamraine
approved these changes
May 23, 2023
connorjclark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor thing I noticed.
once #15091 lands we can probably delete all these estimates, but we'll probably first want to get the ssl timing from LR working. Until then, here's a quick fix to not include one too many roundtrips in these estimates for h3.