Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(largest-contentful-paint-element): display LCP value #15061

Merged
merged 5 commits into from
Jun 12, 2023

Conversation

adamraine
Copy link
Member

We discussed doing this in 🔒 go/lighthouse-lcp-phases

This also includes some code cleanup that changes how we handle the N/A case.

@adamraine adamraine requested a review from a team as a code owner May 10, 2023 19:40
@adamraine adamraine requested review from brendankenny and removed request for a team May 10, 2023 19:40
@adamraine adamraine changed the title core(largest-contentful-paint-element): use LCP timing as display value core(largest-contentful-paint-element): display LCP value Jun 12, 2023
@adamraine adamraine merged commit 1bae933 into main Jun 12, 2023
@adamraine adamraine deleted the lcp-elem-timing branch June 12, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants