deps(lighthouse-stack-packs): upgrade to 1.10.0 #15038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
approved these changes
May 3, 2023
brendankenny
reviewed
May 3, 2023
| @@ -730,8 +730,16 @@ function checkKnownFixedCollisions(strings) { | |||
| 'Potential Savings', | |||
| 'The page was evicted from the cache to allow another page to be cached.', | |||
| 'The page was evicted from the cache to allow another page to be cached.', | |||
| 'Use $MARKDOWN_SNIPPET_0$ to detect unused JavaScript code. $LINK_START_0$Learn more$LINK_END_0$', | |||
There was a problem hiding this comment.
a few of these look like it's a waste to translate twice. e.g.
and
are already the same, just the gatsby one is missing the trailing .
There was a problem hiding this comment.
made a note for this here GoogleChrome/lighthouse-stack-packs#94
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.