Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shorthand property name in module.exports #150

Merged
merged 2 commits into from
Apr 7, 2016
Merged

Use shorthand property name in module.exports #150

merged 2 commits into from
Apr 7, 2016

Conversation

umaar
Copy link
Contributor

@umaar umaar commented Apr 7, 2016

No description provided.

@samccone
Copy link
Contributor

samccone commented Apr 7, 2016

👍 nice

@samccone samccone added the +1 label Apr 7, 2016
enableNetworkThrottling: enableNetworkThrottling,
disableCache: disableCache
};
module.exports = {enableNexus5X, enableNetworkThrottling, disableCache};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure how others feel, but I actually prefer each item on its own line, for easy reading

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to multiline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Thanks for the feedback.

@brendankenny
Copy link
Member

💥

@brendankenny brendankenny added the +2 label Apr 7, 2016
@brendankenny brendankenny merged commit 6fa6e1a into GoogleChrome:master Apr 7, 2016
@brendankenny
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants