-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc(logger): add warn level #14964
misc(logger): add warn level #14964
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some failing tests to address FYI
@connorjclark That's pretty odd typing a little bit. Any suggestions what should be done about it? |
If you can send a PR to update chrome-launcher in the same way, we can update all at once. Another option is to add |
@connorjclark |
Thanks @doteric! |
Summary
There is a missing log level between error and info which is simply
warn
to show just errors and warnings and nothing else. Very small and simple change required to add some better experience.