misc: mark dependencies of entity classification computed artifact #14732
Conversation
alexnj
changed the title
| @@ -98,5 +98,6 @@ class EntityClassification { | |||
| } | |||
| } | |||
|
|
|||
| const EntityClassificationComputed = makeComputedArtifact(EntityClassification, null); | |||
| const EntityClassificationComputed = makeComputedArtifact(EntityClassification, | |||
There was a problem hiding this comment.
can you update all calls to this computed artifact to only pass in these two values? Otherwise, the caching doesn't work.
There was a problem hiding this comment.
Can you explain? May be I'm reading this wrong, but it seems to pick only those dependencies picked via keys supplied during makeComputedArtifact. I've updated the one remaining call that had more than the required two parameters passed, but it didn't seem to create any difference in sample.json.
There was a problem hiding this comment.
Ah, I forgot we did that part recently. All good. For some reason I though the dep thing was just a type hint ... But nah we do runtime stuff to ensure the caching works well
| { | ||
| "startTime": 0, | ||
| "name": "lh:computed:EntityClassification", | ||
| "duration": 100, |
There was a problem hiding this comment.
this kinda suggests that the computed audit isnt being run....
seems odd.
There was a problem hiding this comment.
It was being run multiple times no? This PR removes the unnecessary run.
No description provided.