Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: replace Page.getResourceTree with Page.getFrameTree #14663

Merged
merged 3 commits into from
Jan 12, 2023
Merged

core: replace Page.getResourceTree with Page.getFrameTree #14663

merged 3 commits into from
Jan 12, 2023

Conversation

adamraine
Copy link
Member

@adamraine adamraine requested a review from a team as a code owner January 11, 2023 20:26
@adamraine adamraine requested review from brendankenny and removed request for a team January 11, 2023 20:26
connorjclark
connorjclark approved these changes Jan 11, 2023
View reviewed changes
Copy link
Collaborator

@connorjclark connorjclark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less data over the protocol is good regardless of if it actually fixes the issue, so +1 on that front.

Can you re-run CI a number of times in this PR to see if it fixed it?

@adamraine
Copy link
Member Author

It didn't work, back to the drawing board:
https://github.com/GoogleChrome/lighthouse/actions/runs/3896437240/jobs/6653354464

@adamraine adamraine closed this Jan 11, 2023
@adamraine adamraine mentioned this pull request Jan 11, 2023
Closed
@adamraine adamraine reopened this Jan 11, 2023
@adamraine
Copy link
Member Author

I think the issue in my previous comment was fixed by #14465 when we changed the jump url from about:blank to chrome://terms. #14465 seemed to replace that error with a different error that this PR hopefully addresses. I've tried e2e tests on this patch after #14465 landed and haven't seen any errors yet.

I'm gonna merge this for the reason connor mentioned and the possibility that this fixes the problem.

@adamraine adamraine merged commit cca68a0 into main Jan 12, 2023
@adamraine adamraine deleted the resource-tree-to-frame-tree branch January 12, 2023 00:21
@adamraine adamraine mentioned this pull request Jan 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorjclark connorjclark connorjclark approved these changes

@brendankenny brendankenny Awaiting requested review from brendankenny brendankenny is a code owner automatically assigned from GoogleChrome/lighthouse-hackers

Assignees

@brendankenny brendankenny

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamraine @connorjclark @brendankenny @devtools-bot