report: screen emulation and dpr in meta tooltip #14515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested review from
brendankenny
and removed request for
a team
connorjclark
commented
Nov 10, 2022
| const screenEmulation = settings.screenEmulation.disabled ? | ||
| undefined : | ||
| // eslint-disable-next-line max-len | ||
| `${settings.screenEmulation.width}x${settings.screenEmulation.height}, DPR ${settings.screenEmulation.deviceScaleFactor}`; |
There was a problem hiding this comment.
Continuing our tradition of not properly localizing these strings.
connorjclark
commented
Nov 10, 2022
| `${Util.i18n.strings.runtimeSettingsBenchmark}: ${benchmarkIndex}` + | ||
| `\n${Util.i18n.strings.runtimeSettingsCPUThrottling}: ${envValues.cpuThrottling}` + | ||
| (axeVersion ? `\n${Util.i18n.strings.runtimeSettingsAxeVersion}: ${axeVersion}` : '')], | ||
| devicesTooltipTextLines.join('\n')], |
There was a problem hiding this comment.
minor refactor for readability.
connorjclark
commented
Nov 10, 2022
| @@ -516,14 +516,19 @@ class Util { | |||
| summary = cpuThrottling = networkThrottling = Util.i18n.strings.runtimeUnknown; | |||
| } | |||
|
|
|||
| // TODO(paulirish): revise Runtime Settings strings: https://github.com/GoogleChrome/lighthouse/pull/11796 | |||
paulirish
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14498
report:
flow:
