Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(csp-xss): prevent meta warning if header CSPs are secure #14490

Merged
merged 3 commits into from
Nov 4, 2022
Merged

core(csp-xss): prevent meta warning if header CSPs are secure #14490

merged 3 commits into from
Nov 4, 2022

Conversation

adamraine
Copy link
Member

Fixes #14489

@adamraine adamraine requested a review from a team as a code owner November 2, 2022 17:51
@adamraine adamraine requested review from brendankenny and removed request for a team November 2, 2022 17:51
@connorjclark connorjclark requested review from connorjclark and removed request for brendankenny November 4, 2022 18:18
connorjclark
connorjclark approved these changes Nov 4, 2022
View reviewed changes
Copy link
Collaborator

@connorjclark connorjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but warning string should probably change

@devtools-bot devtools-bot merged commit f2b2c88 into main Nov 4, 2022
@devtools-bot devtools-bot deleted the csp-ignore-meta branch November 4, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorjclark connorjclark connorjclark approved these changes

Assignees

@connorjclark connorjclark

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page contains a CSP defined in a <meta> tag, and in a HTTP header
4 participants
@adamraine @connorjclark @brendankenny @devtools-bot