Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: static-server can continue if already running #14307

Merged
merged 5 commits into from
Aug 24, 2022
Merged

tests: static-server can continue if already running #14307

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
16bdc59
tests: static-server can continue if already running
paulirish Aug 20, 2022
3116e3c
promise.all version
paulirish Aug 20, 2022
0adb188
back to allSettled. but better
paulirish Aug 20, 2022
d94a511
wasInvokedDirectly
paulirish Aug 20, 2022
d47e4f3
adam's suggestion
paulirish Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions cli/test/fixtures/static-server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import esMain from 'es-main';
import {LH_ROOT} from '../../../root.js';

const HEADER_SAFELIST = new Set(['x-robots-tag', 'link', 'content-security-policy']);
const wasInvokedDirectly = esMain(import.meta);

class Server {
baseDir = `${LH_ROOT}/cli/test/fixtures`;
Expand Down Expand Up @@ -249,20 +250,28 @@ class Server {
async function createServers() {
const servers = [10200, 10503, 10420].map(port => {
const server = new Server(port);
server._server.on('error', e => console.error(e.code, e));
server._server.on('error', e => console.error(e.message));
if (wasInvokedDirectly) {
server._server.on('listening', _ => console.log(`listening on http://localhost:${port}`));
}
return server;
});
await Promise.all(servers.map(s => s.listen(s._port, 'localhost')));

const outcomes = await Promise.allSettled(servers.map(s => s.listen(s._port, 'localhost')));
if (outcomes.some(o => o.status === 'rejected')) {
if (outcomes.every(o => o.reason.message.includes('already'))) {
console.warn('😧 Server already up. Continuing…');
} else {
console.error(outcomes.map(o => o.reason));
throw new Error('One or more servers did not start correctly');
}
}
return servers;
}

// If called directly (such as via `yarn static-server`) then start all of the servers.
if (esMain(import.meta)) {
createServers().then(servers => {
for (const server of servers) {
console.log(`listening on http://localhost:${server._port}`);
}
});
if (wasInvokedDirectly) {
createServers();
}

export {
Expand Down