core(i18n): delete i18n.createMessageInstanceIdFn
#14251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
reviewed
Aug 2, 2022
There was a problem hiding this comment.
Change looks good to me for our code! This has to be breaking pubads, though. I assume that won't show up in our tests until #14241 lands reenables the pubads tests.
We should fix it over there too, and it should also be just a text replacement since the new function has been shipping for so long, but I don't know if we want to deal with branches and release schedules over there too (on top of the ESM stuff), so maybe it is better to leave the old method in for now with an @deprecated tag.
|
Actually, I just opened a PR to fix it right now. Go ahead with a full removal here. |
connorjclark
approved these changes
Aug 3, 2022
alexnj
changed the title
i18n.createMessageInstanceIdFni18n.createMessageInstanceIdFn
adamraine
approved these changes
Aug 8, 2022
alexnj
added a commit
to alexnj/lighthouse
that referenced
this pull request
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the legacy
i18n.createMessageInstanceIdFnmethod in favor of the newcreateIcuMessageFnintroduced in #10630.If we have external dependencies that rely on this method, they will have to be updated.
Fixes #13993.