Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(user-flows): fix the order of the mode thumbnail images #14219

Merged
merged 1 commit into from
Jul 18, 2022
Merged

docs(user-flows): fix the order of the mode thumbnail images #14219

merged 1 commit into from
Jul 18, 2022

Conversation

hackurity01
Copy link
Contributor

@hackurity01 hackurity01 commented Jul 17, 2022 •
edited
Loading

It seems that the representations in the images do not match each other.

image

�Changes

  • I exchanged images of Timespan and Snapshot in user-flows.md.

@hackurity01 hackurity01 requested a review from a team as a code owner July 17, 2022 10:51
@hackurity01 hackurity01 requested review from connorjclark and removed request for a team July 17, 2022 10:51
@google-cla
Copy link

google-cla bot commented Jul 17, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hackurity01 hackurity01 changed the title docs: Change the order of the mode description images in user-flows.md docs: change the order of the mode description images in user-flows.md Jul 17, 2022
@adamraine adamraine changed the title docs: change the order of the mode description images in user-flows.md docs(user-flows): fix the order of the mode thumbnail images Jul 18, 2022
adamraine
adamraine approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@adamraine adamraine merged commit d956ec9 into GoogleChrome:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamraine adamraine adamraine approved these changes

@connorjclark connorjclark Awaiting requested review from connorjclark connorjclark was automatically assigned from GoogleChrome/lighthouse-hackers

Assignees

@connorjclark connorjclark

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hackurity01 @adamraine @connorjclark @devtools-bot