Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(smoke): reenable oopif smokes with ToT #14153

Merged
merged 15 commits into from
Jul 7, 2022
Merged

tests(smoke): reenable oopif smokes with ToT #14153

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
18baff6
start
adamraine Jun 23, 2022
d74b655
job
adamraine Jun 23, 2022
26165ab
ok
adamraine Jun 23, 2022
46483dd
oopif-scripts
adamraine Jun 23, 2022
b1d1858
ok
adamraine Jun 23, 2022
cb867df
legacy dt log
adamraine Jun 24, 2022
969eadb
Merge branch 'master' into try-reenable-some-smokes
adamraine Jun 27, 2022
175cdd7
Merge branch 'master' into try-reenable-some-smokes
adamraine Jun 29, 2022
7194e6d
tot for normal bundle
adamraine Jun 29, 2022
eb566ce
windows
adamraine Jun 30, 2022
ce9ec3f
WINDOWS
adamraine Jul 1, 2022
a0550bb
no tot package
adamraine Jul 6, 2022
9e7f64c
version checks
adamraine Jul 6, 2022
6be5fc4
ope
adamraine Jul 6, 2022
9d1c9f9
Merge branch 'master' into try-reenable-some-smokes
adamraine Jul 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/devtools.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,7 @@ jobs:
# errors-expired-ssl errors-infinite-loop
# Disabled because Chrome will follow the redirect first, and Lighthouse will only ever see/run the final URL.
# redirects-client-paint-server redirects-multiple-server redirects-single-server redirects-single-client
# Disabled to fix CI while we investigate what the bug is.
# oopif-scripts
run: yarn smoke --runner devtools --shard=${{ matrix.smoke-test-shard }}/${{ strategy.job-total }} --jobs=3 --retries=2 --invert-match oopif-scripts a11y byte-efficiency byte-gzip dbw errors-expired-ssl errors-infinite-loop lantern-idle-callback-short legacy-javascript metrics-tricky-tti metrics-tricky-tti-late-fcp oopif-requests perf-budgets perf-diagnostics-third-party perf-fonts perf-frame-metrics perf-preload perf-trace-elements pwa redirects-client-paint-server redirects-history-push-state redirects-multiple-server redirects-single-server redirects-single-client redirects-scripts screenshot seo-passing seo-tap-targets
run: yarn smoke --runner devtools --shard=${{ matrix.smoke-test-shard }}/${{ strategy.job-total }} --jobs=3 --retries=2 --invert-match a11y byte-efficiency byte-gzip dbw errors-expired-ssl errors-infinite-loop lantern-idle-callback-short legacy-javascript metrics-tricky-tti metrics-tricky-tti-late-fcp perf-budgets perf-fonts perf-frame-metrics perf-preload perf-trace-elements pwa redirects-client-paint-server redirects-history-push-state redirects-multiple-server redirects-single-server redirects-single-client redirects-scripts screenshot seo-passing seo-tap-targets
working-directory: ${{ github.workspace }}/lighthouse

- name: Upload failures
Expand Down
11 changes: 8 additions & 3 deletions .github/workflows/package-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,14 @@ jobs:
- run: yarn build-report
- run: sudo apt-get install xvfb

# Disabled to fix CI while we investigate what the bug is.
# perf-diagnostics-third-party, oopif-requests, oopif-scripts
- run: xvfb-run --auto-servernum bash $GITHUB_WORKSPACE/lighthouse-core/scripts/release/package-test.sh --fraggle-rock --invert-match perf-diagnostics-third-party oopif-requests oopif-scripts
- name: Define ToT chrome path
run: echo "CHROME_PATH=/home/runner/chrome-linux-tot/chrome" >> $GITHUB_ENV

- name: Install Chrome ToT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this (and the other cases) include a TODO to eventually move back to stable?

Also, what's left testing stable?

Copy link
Member Author

@adamraine adamraine Jun 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Bundled Lighthouse (Legacy navigation)
  • Package test (Legacy navigation)
  • Chrome stable smokes from the standard matrix
  • Windows

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this (and the other cases) include a TODO to eventually move back to stable?

TBH I'm fine shifting everything (except our explicitly Chrome stable smokes) to use ToT

working-directory: /home/runner
run: bash $GITHUB_WORKSPACE/lighthouse-core/scripts/download-chrome.sh && mv chrome-linux chrome-linux-tot

- run: xvfb-run --auto-servernum bash $GITHUB_WORKSPACE/lighthouse-core/scripts/release/package-test.sh --fraggle-rock

# Fail if any changes were written to source files.
- run: git diff --exit-code
22 changes: 16 additions & 6 deletions .github/workflows/smoke.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,16 @@ jobs:
- run: yarn build-report
- run: yarn reset-link

- name: Define ToT chrome path
run: echo "CHROME_PATH=/home/runner/chrome-linux-tot/chrome" >> $GITHUB_ENV

- name: Install Chrome ToT
working-directory: /home/runner
run: bash $GITHUB_WORKSPACE/lighthouse-core/scripts/download-chrome.sh && mv chrome-linux chrome-linux-tot

- run: sudo apt-get install xvfb
- name: yarn smoke --fraggle-rock
# Disabled to fix CI while we investigate what the bug is.
# perf-diagnostics-third-party, oopif-requests, oopif-scripts
run: xvfb-run --auto-servernum yarn smoke --debug --fraggle-rock -j=2 --retries=2 --shard=${{ matrix.smoke-test-shard }}/$SHARD_TOTAL --invert-match perf-diagnostics-third-party oopif-requests oopif-scripts
run: xvfb-run --auto-servernum yarn smoke --debug --fraggle-rock -j=2 --retries=2 --shard=${{ matrix.smoke-test-shard }}/$SHARD_TOTAL

# Fail if any changes were written to source files.
- run: git diff --exit-code
Expand Down Expand Up @@ -217,11 +222,16 @@ jobs:
- run: yarn build-report
- run: yarn build-devtools

- name: Define ToT chrome path
run: echo "CHROME_PATH=/home/runner/chrome-linux-tot/chrome" >> $GITHUB_ENV

- name: Install Chrome ToT
working-directory: /home/runner
run: bash $GITHUB_WORKSPACE/lighthouse-core/scripts/download-chrome.sh && mv chrome-linux chrome-linux-tot

- run: sudo apt-get install xvfb
- name: yarn test-bundle
# Disabled to fix CI while we investigate what the bug is.
# perf-diagnostics-third-party, oopif-requests, oopif-scripts
run: xvfb-run --auto-servernum yarn test-bundle --fraggle-rock --shard=${{ matrix.smoke-test-shard }}/$SHARD_TOTAL --invert-match perf-diagnostics-third-party oopif-requests oopif-scripts
run: xvfb-run --auto-servernum yarn test-bundle --fraggle-rock --shard=${{ matrix.smoke-test-shard }}/$SHARD_TOTAL

# Fail if any changes were written to source files.
- run: git diff --exit-code
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/gather/driver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class Driver {
* @private
* Used to save network and lifecycle protocol traffic. Just Page and Network are needed.
*/
_devtoolsLog = new DevtoolsMessageLog(/^(Page|Network)\./);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulirish was this intentionally left out of #14080?

Copy link
Collaborator

@connorjclark connorjclark Jun 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just for debugging. Can you open a new PR?

I'm thinking it was a merge mistake that dropped this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah im pretty sure i messed up a conflict resolution merge. thx for the driveby

_devtoolsLog = new DevtoolsMessageLog(/^(Page|Network|Target|Runtime)\./);

/**
* @private
Expand Down