Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(smoke): add an option and cli flag to control test exclusion #14135

Closed
wants to merge 1 commit into from

Conversation

alexnj
Copy link
Member

@alexnj alexnj commented Jun 16, 2022

Addresses #14127.

This implements an exclude list to the smoke test definition that should help to exclude a test from a specific runner or all runners.

Example:

 export default {
   id: 'foo',
   expectations,
   config,
+  exclude: ['devtools', 'cli'],
 };

A test can be excluded from all runners by specifying exclude: ['*'].

In order to temporarily ignore an exclusion for debugging, Smoke CLI now features a boolean flag --ignore-exclusions.

@connorjclark I chose to retain the list as a fixed structure instead of exclude being a boolean.

@brendankenny
Copy link
Member

added some thoughts to #14127 about the approach

@alexnj
Copy link
Member Author

alexnj commented Aug 24, 2022

Closing this PR; will raise a new one that addresses the feedback.

@alexnj alexnj closed this Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants